D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  In D16951#363898 , @ndavis wrote:
  
  > So now I have 2 commits and one of them is already on master, but they're 
both called "Add mouse button icons" and use the same description. Should I 
update this diff to describe only the latest commit or make it apply to both?
  
  
  Just rename this one to something like "Resolve merge conflict"

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  So now I have 2 commits and one of them is already on master, but they're 
both called "Add mouse button icons" and use the same description. Should I 
update this diff to describe only the latest commit or make it apply to both?

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45981.
ndavis marked an inline comment as done.
ndavis added a comment.


  Rebase onto master again

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45980=45981

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons/actions/16/dialog-input-devices.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951_1

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  Ok, I see what the issue was. The conflicts are literally stored *in* the 
file that has the conflict as text, so `dialog-input-devices.svg` was turned 
into a diff of the old and new versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45980.
ndavis added a comment.


  Fix conflicts

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45979=45980

BRANCH
  arcpatch-D16951_1

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  This assumes the files that you uploaded before the merge are all correct.
  
  - Save the correct icons somewhere.
  - Checkout the old diff: arc patch --diff 45755
  - Begin rebase: git rebase master
  - Override the files with conflicts with the files you saved
  - git add files
  - git rebase --continue
  - Upload it: arc diff

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#363879 , @nicolasfella 
wrote:
  
  > In D16951#363878 , @ndavis wrote:
  >
  > > Save what or how? Doesn't `arc diff --update D16951` save things? I know 
I added the right files and there were only 2 conflicts 
(`icons/actions/16/dialog-input-devices.svg` and 
`icons-dark/actions/16/dialog-input-devices.svg`).
  >
  >
  > Saved in the program you resolved the conflict with
  >
  > > I just pulled the patch with `arc patch D16951`
  > >  If I do `git status`, it says
  > > 
  > >   On branch arcpatch-D16951
  > >nothing to commit, working tree clean
  > > 
  > > This is what Git looks like in `git-dag`:
  > >  F6435866: Screenshot_20181121_180633.png 

  >
  > git thinks everything is ok, but the merge conflict markers are still in 
the file.
  >
  > I think you should restore the unmerged version, merge again, resolve the 
conflict and upload it again
  
  
  How do I do this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  In D16951#363878 , @ndavis wrote:
  
  > Save what or how? Doesn't `arc diff --update D16951` save things? I know I 
added the right files and there were only 2 conflicts 
(`icons/actions/16/dialog-input-devices.svg` and 
`icons-dark/actions/16/dialog-input-devices.svg`).
  
  
  Saved in the program you resolved the conflict with
  
  > I just pulled the patch with `arc patch D16951`
  >  If I do `git status`, it says
  > 
  >   On branch arcpatch-D16951
  >nothing to commit, working tree clean
  > 
  > This is what Git looks like in `git-dag`:
  >  F6435866: Screenshot_20181121_180633.png 

  
  git thinks everything is ok, but the merge conflict markers are still in the 
file.
  
  I think you should restore the unmerged version, merge again, resolve the 
conflict and upload it again

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#363876 , @nicolasfella 
wrote:
  
  > In D16951#363875 , @ndavis wrote:
  >
  > > I thought I did this already. I rebased onto master, then added the 
version of the file I wanted, then continued the rebase, then updated the diff. 
Is there something I missed?
  >
  >
  > Sounds reasonable. Maybe you forgot to save, or forgot to add a file or 
added the wrong file.
  
  
  Save what or how? Doesn't `arc diff --update D16951` save things? I know I 
added the right files and there were only 2 conflicts 
(`icons/actions/16/dialog-input-devices.svg` and 
`icons-dark/actions/16/dialog-input-devices.svg`).
  
  I just pulled the patch with `arc patch D16951`
  If I do `git status`, it says
  
On branch arcpatch-D16951
nothing to commit, working tree clean
  
  This is what Git looks like in `git-dag`:
  F6435866: Screenshot_20181121_180633.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  I any case, try again and check the files for merge conflict markers

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  In D16951#363875 , @ndavis wrote:
  
  > I thought I did this already. I rebased onto master, then added the version 
of the file I wanted, then continued the rebase, then updated the diff. Is 
there something I missed?
  
  
  Sounds reasonable. Maybe you forgot to save, or forgot to add a file or added 
the wrong file.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  I thought I did this already. I rebased onto master, then added the version 
of the file I wanted, then continued the rebase, then updated the diff. Is 
there something I missed?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> dialog-input-devices.svg:3
>  

D16951: Add mouse button icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6976172920e2: Add mouse button icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45978=45979

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#363861 , @nicolasfella 
wrote:
  
  > Looks great!
  
  
  Ah thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45978.
ndavis added a comment.


  Rebase onto master

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45755=45978

BRANCH
  arcpatch-D16951

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.


  Looks great!

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  It's been 3 days and no response. It has already been approved by another 
reviewer, so I'm going to land this now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Albert Vaca Cintora]

albertvaka added a reviewer: KDE Connect.

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: nicolasfella.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good to me now! Let's make sure @nicolasfella is happy too, since he's 
going to be the inaugural user. :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg, ngraham, nicolasfella
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis updated this revision to Diff 45755.
ndavis added a comment.


  Detach MMB, increase highlight length, make colors match new HIG, turn MMB 
click highligh into outline

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16951?vs=45703=45755

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/dialog-input-devices.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nicolas Fella]

nicolasfella added a comment.


  Looks good! +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[TrickyRicky]

trickyricky26 added a comment.


  I think it's not quite clear enough on it's own, however together with the 
other icons it will be clear

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  F6430803: Screenshot_20181118_123558.png 

  
  Is this too small or not legible enough?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[TrickyRicky]

trickyricky26 added a comment.


  I would suggest making the mouse wheel itself turn blue as highlighting

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#361317 , @ngraham wrote:
  
  > What about making the MMB turn white when it has the blue highlight?
  
  
  white MMB F642: Screenshot_20181118_005525.png 

  
  white MMB with slightly longer highlight next to right click icon with 
original highlight length F6430002: Screenshot_20181118_005628.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham added a comment.


  What about making the MMB turn white when it has the blue highlight?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#361294 , @ngraham wrote:
  
  > Much better shape!
  >
  > What do you think about making the mouse wheel detached from the top of the 
mouse so it looks more like a wheel and less like a notch? Then also you might 
not need to omit it from `input-mouse-click-middle`'
  
  
  It does look better on the other mouse icons, but the middle mouse button 
still needs to be covered by the blue highlight because otherwise the highlight 
is too difficult to see.
  
  detached MMB F6429945: Screenshot_20181118_001313.png 

  
  highlight under detached MMB F6429909: Screenshot_20181118_000942.png 

  
  slightly longer highlight under detached MMB F6429942: 
Screenshot_20181118_000920.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham added a comment.


  Much better shape!
  
  What do you think about making the mouse wheel detached from the top of the 
mouse so it looks more like a wheel and less like a notch? Then also you might 
not need to omit it from `input-mouse-click-middle`'

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Andres Betts]

abetts added a comment.


  Looks good to me +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis planned changes to this revision.
ndavis added a comment.


  Alright, that's 2 people in favor of a curved mouse. After all, we're not 
using Apple Macintoshes from the 80s.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Nathaniel Graham]

ngraham added a comment.


  +1 for more curves. That rectangle doesn't particular scream "I'm a mouse!" 
to me.
  
  `dialog-input-devices` itself is pretty lousy, honestly. It would also use a 
bit of sprucing up rather than copying its style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a comment.


  In D16951#360965 , @rizzitello 
wrote:
  
  > I think the Mouse itself needs a bit more curve with less box.
  
  
  I kind of agree. I was just copying the existing `dialog-input-devices` icon, 
but I suppose I could change that as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Chris Rizzitello]

rizzitello added a comment.


  I think the Mouse itself needs a bit more curve with less box.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis added a subscriber: nicolasfella.
ndavis added a comment.


  @nicolasfella Will these work for you? Let me know if you need thumb buttons 
as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Add left, middle and right click icons for KDE Connect
  
  FEATURE: 399295
  FIXED-IN: 5.53

REPOSITORY
  R266 Breeze Icons

BRANCH
  mouse-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16951

AFFECTED FILES
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/22/input-mouse-click-left.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-right.svg
  icons/actions/16/input-mouse-click-left.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-right.svg
  icons/actions/22/input-mouse-click-left.svg
  icons/actions/22/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-right.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns