D17295: BrightScript: Add function/sub folding

2018-12-08 Thread Dominik Haumann 
dhaumann added inline comments.

INLINE COMMENTS

> brightscript.xml:290
>   
> - 
> - 

Since this context is not used anymore, we gen a warning while creating the 
highlighting index:

  [  9%] Generating index.katesyntax
  testkatehighlightingindexer(31350)/(default) ::KeywordChecker::check: 
"/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml"
 Unused keyword lists: QSet("end")

--> the keyword list end should be removed, since unused.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17295

To: dlevin, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17295: BrightScript: Add function/sub folding

2018-12-02 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:50a65cb06c37: BrightScript: Add function/sub folding 
(authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17295?vs=46667=46695

REVISION DETAIL
  https://phabricator.kde.org/D17295

AFFECTED FILES
  autotests/folding/brightscript.brs.fold
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17295: BrightScript: Add function/sub folding

2018-12-02 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17295

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17295: BrightScript: Add function/sub folding

2018-12-01 Thread Daniel Levin 
dlevin updated this revision to Diff 46667.
dlevin added a comment.


  Increased version number.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17295?vs=4=46667

REVISION DETAIL
  https://phabricator.kde.org/D17295

AFFECTED FILES
  autotests/folding/brightscript.brs.fold
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17295: BrightScript: Add function/sub folding

2018-12-01 Thread Daniel Levin 
dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Global and local function folding, including closures.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17295

AFFECTED FILES
  autotests/folding/brightscript.brs.fold
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann