D17436: BrightScript: Remove unused keyword list 'end'

2018-12-10 Thread Daniel Levin
dlevin added a comment. Thanks for the fix, yes it is valid. Previously "end" was used as a standalone keyword, but keyword requires space after the word. Now it used in StringDetect to detect cases like "end sub" and "endsub" in the same rule. REPOSITORY R216 Syntax Highlighting REVISION

D17436: BrightScript: Remove unused keyword list 'end'

2018-12-09 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:d4c10b4533ed: BrightScript: Remove unused keyword list 'end' (authored by dhaumann, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D17436: BrightScript: Remove unused keyword list 'end'

2018-12-09 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. If not used, I shall go, no need to have the warning around. REPOSITORY R216 Syntax Highlighting BRANCH fix_brightscript REVISION DETAIL https://phabricator.kde.org/D17436 To: d

D17436: BrightScript: Remove unused keyword list 'end'

2018-12-08 Thread Dominik Haumann
dhaumann updated this revision to Diff 47134. dhaumann added a comment. - increase version number only by one :-) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17436?vs=47131&id=47134 BRANCH fix_brightscript REVISION DETAIL https://phabri

D17436: BrightScript: Remove unused keyword list 'end'

2018-12-08 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: dlevin, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This warning was introduced with D17295