D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:bd398cc43389: Change default sort order in the download 
dialog to Most downloads (authored by GB_2, committed by ngraham).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17641?vs=47724=48264

REVISION DETAIL
  https://phabricator.kde.org/D17641

AFFECTED FILES
  src/downloadwidget.cpp
  src/downloadwidget.ui

To: GB_2, #frameworks, #vdg, ngraham
Cc: ngraham, filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Björn Feber
GB_2 added a comment.


  Thanks.
  I will apply when when I have time!

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

To: GB_2, #frameworks, #vdg, ngraham
Cc: ngraham, filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This seems like a reasonable enhancement to me. Do you have commit access yet?
  
  If not, consider applying! :) 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

To: GB_2, #frameworks, #vdg, ngraham
Cc: ngraham, filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-27 Thread Björn Feber
GB_2 added a comment.


  Ping?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

To: GB_2, #frameworks, #vdg
Cc: filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, firef, 
ngraham, bruns, skadinna, aaronhoneycutt, mbohlender


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef, ngraham, 
bruns, skadinna, aaronhoneycutt, mbohlender


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 created this revision.
GB_2 added reviewers: Frameworks, VDG.
GB_2 added projects: Frameworks, VDG.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 399163
  
  This changes the default sort ordering of the download dialog to "Most 
downloads" (in 3 months), because the current problem is that the items sorted 
by rating are sometimes very old and often don't work anymore.
  When you change the dort order to "Most downloads" it shows the items that 
are actually popular (many downloads in 3 months) and they are are more up to 
date.

TEST PLAN
  Open a GHNS dialog and see that the default sort ordering of the content is 
by "Most downloads", and that the "Most downloads" radio button is checked.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

AFFECTED FILES
  src/downloadwidget.cpp
  src/downloadwidget.ui

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef, ngraham, 
bruns, skadinna, aaronhoneycutt, mbohlender