D17932: Improvements to completion

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:7c42ba4a1aed: Improvements to completion (authored by thomassc, committed by cullmann). REPOSITORY R39 KTextEditor

D17932: Improvements to completion

cullmann accepted this revision. cullmann added a comment. Then I will apply this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff, cullmann Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel,

D17932: Improvements to completion

mwolff added a comment. I'm in favor! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,

D17932: Improvements to completion

dhaumann added a comment. Well, giving it a try and merge should be postponed ubtil tomorrow: dfaure tags today, so we would then have 1 month of internal testing. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop,

D17932: Improvements to completion

cullmann added a comment. Should we give this some try and merge it? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, hase,

D17932: Improvements to completion

mwolff accepted this revision as: mwolff. mwolff added a comment. @brauch, @kfunk what do you say? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel,

D17932: Improvements to completion

thomassc updated this revision to Diff 49397. thomassc added a comment. Change to a single setter for match_cs and exact_match_cs to avoid restriction on call order of functions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17932?vs=49343=49397

D17932: Improvements to completion

mwolff added subscribers: brauch, kfunk, apol. mwolff added a comment. In D17932#392060 , @thomassc wrote: > Thanks for reviewing. Regarding the question about which models would have an insensitive exact match, and which ones have sensitive

D17932: Improvements to completion

thomassc updated this revision to Diff 49343. thomassc added a comment. Update according to Milian's comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17932?vs=48574=49343 BRANCH improvements_to_completion (branched from master) REVISION

D17932: Improvements to completion

thomassc marked 4 inline comments as done. thomassc added a comment. Thanks for reviewing. Regarding the question about which models would have an insensitive exact match, and which ones have sensitive exact matches: - An example for case-insensitive exact matches might be plain text, or

D17932: Improvements to completion

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. Hey there, sorry for the long delay. In general, I think your suggestions are very sane - most notably preferring exact case matches over fuzzy matches is a good thing to have!

D17932: Improvements to completion

cullmann added a reviewer: KDevelop. cullmann added a comment. Perhaps some KDevelop people have feedback, given they use that mostly ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop Cc: cullmann, kwrite-devel,

D17932: Improvements to completion

thomassc created this revision. thomassc added a reviewer: KTextEditor. thomassc added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision. REVISION SUMMARY My goal is to fix