D17998: test to fix cpp indenter

2019-01-08 Thread Christoph Cullmann 
cullmann abandoned this revision.
cullmann added a comment.


  See
  
  https://codereview.qt-project.org/#/c/249358/
  
  There will be a fix in Qt (perhaps 5.12.1)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17998

To: cullmann, dhaumann, carewolf, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17998: test to fix cpp indenter

2019-01-07 Thread Christoph Cullmann 
cullmann added a comment.


  I c reated a Qt bug, I still think this is some regression.
  
  https://bugreports.qt.io/browse/QTBUG-72879

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17998

To: cullmann, dhaumann, carewolf, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17998: test to fix cpp indenter

2019-01-05 Thread Christoph Cullmann 
cullmann added reviewers: carewolf, Frameworks.
cullmann added a comment.


  Hi ;=)
  
  I have some dumb javascript / QJSEngine question:
  
  With Qt 5.12, the regex above
  
  var r = /^(\s*)(([\)\]}]?\s*)*([\)\]]\s*))?;/.exec(prevString);
  
  executes successfully on a "prevString" containing
  
  'ok'
  
  I am a bit confused, why.
  The ";" at the end of the regex is not optional, why do I get a non-null r?
  Funny enough, the full capture r[0] is empty.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17998

To: cullmann, dhaumann, carewolf, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17998: test to fix cpp indenter

2019-01-05 Thread Christoph Cullmann 
cullmann created this revision.
cullmann added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  cppstyle indenter is broken with Qt 5.12
  
  this commit shall not be applied as is, I don't get why the null check does 
no longer work

TEST PLAN
  make test works again with this patch

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17998

AFFECTED FILES
  src/script/data/indentation/cppstyle.js

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann