D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

This revision was automatically updated to reflect the committed changes. Closed by commit R295:24ba84914a84: [kcmutils] Add ellipsis to search labels in KPluginSelector (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this is fine. The search field doesn't have to specify what it's going to be searching in if it's totally obvious, as it is here. This also makes it consistent with other similar

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty added inline comments. INLINE COMMENTS > pino wrote in kpluginselector.cpp:261 > a) explicit is better than implicit > b) "shorter" makes sense only when thinking for English, not for other > languages a) not always - there's very little nuance here, and there's nothing to be gained by

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

pino added inline comments. INLINE COMMENTS > rooty wrote in kpluginselector.cpp:261 > i think it's because it's self-evident (and shorter) a) explicit is better than implicit b) "shorter" makes sense only when thinking for English, not for other languages REPOSITORY R295 KCMUtils REVISION

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty added inline comments. INLINE COMMENTS > pino wrote in kpluginselector.cpp:261 > why not "Search plugins..."? i think it's because it's self-evident (and shorter) REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty, #vdg, #plasma,

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham,

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty added reviewers: VDG, Plasma, kde-frameworks-devel. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

pino added inline comments. INLINE COMMENTS > kpluginselector.cpp:261 > d->lineEdit->setClearButtonEnabled(true); > -d->lineEdit->setPlaceholderText(i18n("Search Plugins")); > +d->lineEdit->setPlaceholderText(i18n("Search...")); > d->listView = new KCategorizedView(this); why

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

shubham added a comment. I don't think so, next time when you can push this type of change (ellipsis) directly, there is a task about it if you know. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty Cc: shubham, kde-frameworks-devel, michaelh,

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty added a comment. In D18043#388194 , @shubham wrote: > I don't think so, next time when you can push this type of change (ellipsis) directly, there is a task about it if you know. Cool! REPOSITORY R295 KCMUtils REVISION DETAIL

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty added a comment. In D18043#388191 , @shubham wrote: > +1 hey i ... accidentally ran arc diff without arc feature? is that a problem? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty Cc:

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

shubham added a comment. +1 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds an ellipsis to the search labels in KPluginSelector (and the elements that call for it, e.g. KWin