D19960: bluez-qt: remove warnings

2019-04-09 Thread David Rosca 
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  Actually ...

INLINE COMMENTS

> a2dp-codecs.c:59
>  AAC_OBJECT_TYPE_MPEG4_AAC_SCA, */
> -AAC_INIT_FREQUENCY(
> +AAC_INIT_FREQUENCY((
>  /*AAC_SAMPLING_FREQ_8000 |

Why this?

> a2dp-codecs.h:135
>  #define AAC_INIT_FREQUENCY(f) \
>   .frequency1 = (f >> 4) & 0xff, \
> + .frequency2 = (f) & 0x0f,

Wouldn't `( (f) >> 4)` be enough instead of adding the parenthesis below?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca
Cc: ngraham, pino, kde-frameworks-devel, michaelh, bruns

D19960: bluez-qt: remove warnings

2019-04-09 Thread Nathaniel Graham 
ngraham added a comment.


  @drosca I think you'll have to land this for @carneirogustavo.

REPOSITORY
  R269 BluezQt

BRANCH
  remove_compile_warnings

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca
Cc: ngraham, pino, kde-frameworks-devel, michaelh, bruns

D19960: bluez-qt: remove warnings

2019-04-09 Thread David Rosca 
drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

BRANCH
  remove_compile_warnings

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19960: bluez-qt: remove warnings

2019-04-09 Thread Tomaz Canabrava 
tcanabrava added a comment.


  ping?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19960: bluez-qt: remove warnings

2019-03-30 Thread Pino Toscano 
pino added a comment.


  Please describe what are the warnings: otherwise it is not clear what the 
problem was, and what was the solution implemented.
  Remember: just because you see something on your system, it does not 
necessarly mean everybody else will, so each commit needs a proper explanation 
so everybody can understand why a change was made.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19960: bluez-qt: remove warnings

2019-03-21 Thread Gustavo Carneiro 
carneirogustavo retitled this revision from "remove warnings" to "bluez-qt: 
remove warnings".

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D19960

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric
Cc: kde-frameworks-devel, michaelh, ngraham, bruns