shubham updated this revision to Diff 58351.
shubham edited the summary of this revision.
shubham edited the test plan for this revision.
shubham added a comment.
Rely upon QSysInfo to retrieve the system details
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Please make sure to edit the commit log -- the phabricator description still
says "Refactor and cleanup" ...
REPOSITORY
R241 KIO
BRANCH
cleanup
REVISION DETAIL
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
- The description still says "Refactor and cleanup" (note that phabricator
doesn't auto-update from the commit log, unless you use arc diff --verbatim, so
one often has to
shubham added a comment.
@dfaure Ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
pino added a comment.
Also, please explicitly mention what are the changes done. "refactor and
cleanup" is very vague, while saying that, for example, QSysInfo is used on all
the OSes is better.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure added a comment.
I like the idea.
The commit template has a "Test Plan" field, but it seems it was left empty -
can you detail what tests you did?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh,
shubham created this revision.
shubham added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
cleanup
REVISION DETAIL
https://phabricator.kde.org/D20626
AFFECTED
11 matches
Mail list logo