D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Abandoned in favor of D22144 

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven planned changes to this revision.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60782.
meven added a comment.


  - Add proper logging using ECMQtDeclareLoggingCategory

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60779=60782

BRANCH
  add-logging

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven planned changes to this revision.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60779.
meven added a comment.


  - Add proper logging using ECMQtDeclareLoggingCategory

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60708=60779

BRANCH
  add-logging

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  recentlyused:/ will be moved to kio-extras.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60708.
meven added a comment.


  - Add a logging category kf5.kactivity.stat

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60676=60708

BRANCH
  add-logging

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60676.
meven added a comment.


  Allow to find data accross all activities using ?activity=any

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60653=60676

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven added a comment.


  In D22082#486782 , @ivan wrote:
  
  > I'd add support for `HighScoredFirst` and `RecentlyCreatedFirst`. Maybe the 
protocol could be something like "used:/" or something.
  
  
  Adding sorting options is on my todo-list, I also need a way to enforce this 
ordering in dolphin, perhaps this will be code in dolphin and will be specific 
to this ioslave.
  
  used:/ this to me like a great suggestion. I will probably update the code to 
this.
  
  @ivan Should it be in kio-extras, or do you feel it is fine in 
kactivities-stats repo ?
  
  > It should also support getting items for the current activity, or all 
recently used items.
  
  Yep, it kinda does already, just need to support the "global" special case.
  
  I am putting this in planned changes for now, because I have a few things to 
take care of before it is worth reviewing in depth :
  
  - documentation
  - ResultWatcher and KDirNotify : notify ioslaves users when the content as 
soon as some new content has arrived
  - dolphin must follow sorting of ioslave rather than the one from the 
files/directories
  - needs to check it works with smb nfs sftp differently mounted, needs to 
avoid displaying files on no mounted-drives, and other network-fs related checks
  
  By the way KAcitivityStats library is quite nice to use :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Ivan Čukić]

ivan added a comment.


  I'd add support for `HighScoredFirst` and `RecentlyCreatedFirst`. Maybe the 
protocol could be something like "used:/" or something.
  
  It should also support getting items for the current activity, or all 
recently used items.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60653.
meven added a comment.


  Add activity filtering

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60646=60653

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60646.
meven added a comment.


  Implement proper logging, add url filter parameter

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60633=60646

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven edited reviewers, added: ivan; removed: lunakl.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan, lunakl
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven added a subscriber: ivan.
meven added a comment.


  I have added you @ivan as you were the main author of KAcvitiesStat and might 
be interested in the review.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, lunakl
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven added a reviewer: lunakl.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, lunakl
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60633.
meven added a comment.


  Allow to override default 30 results limit

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60631=60633

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven updated this revision to Diff 60631.
meven added a comment.


  Allow to filter mimetype with ?type=mimetype1[,mimetype2]

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60602=60631

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  To accomplish D7446 , we want to add a 
better recent document ioslave to Dolphin/KFileWidgets than current 
recentdocuments:/
  This adds activity awareness to recent documents.
  
  The code started out of kio-extras recent-documents and Kicker/Kickoff.
  This is my first ioslave so I think I will need a bit of mentoring, if anyone 
feels like it to guide me a little.
  
  This repository may not be the appropriate one, the other obvious candidate 
would be kio-extras.
  
  Future features would allow users to filter parent dir, switch only-folders, 
number of elements returned.

TEST PLAN
  compile
  open recentdocumentsactivities:/ in Dolphin/KFileWidgetItem

REPOSITORY
  R159 KActivities Statistics

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns