D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c8ebfc2530dd: Fix missing digit and pixel-perfect 
alignment of depth action icons (authored by Rafael Brandmaier 
).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23116?vs=63652&id=63757

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D23116#511480 , @trickyricky26 
wrote:
  
  > I thought about that, too, and while the red used in the icon is exactly 
`NegativeText`, the blue in the current icon is darker and has a less vibrant 
hue than `ButtonFocus`, so I'm not quite comfortable with using that for the 
blue color. Do we have this darker blue as a CSS color that we can use in this 
way? I see this dark blue is also used in the `channelmixer` icon, which has 
its colors hardcoded as well. I also don't think it would make sense to only 
use stylesheet colors for only one of these two colors.
  
  
  It's a real shame that we can't specify dedicated icon colors in the 
colorscheme, otherwise that would be a nice blue to use. Or maybe it can be 
done, but it would be complicated. I don't think it's absolutely necessary to 
use ButtonFocus right now.
  
  > Btw, in the relevant HIG page 
(https://hig.kde.org/style/icon.html#action-and-status-icons) the color 
`ColorScheme-ButtonFocus` in the page you linked is called 
`ColorScheme-Highlight` and there are other anme differences, too. Is one of 
these inaccurate, or do they both work?
  
  I need to update the HIG. We switched from Highlight to ButtonFocus because 
Highlight uses the Selection Background color. In the future, I'm going to 
change the Breeze/Breeze Dark colorschemes so that Focus Decoration color and 
Selection Background color are different. This prevents blue icon elements from 
blending in with the selection background.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 added a comment.


  In D23116#511430 , @GB_2 wrote:
  
  > Maybe instead of hardcoding the blue and red colors you can use the 
stylesheet colors `ButtonFocus` and `NegativeText`: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets
  
  
  I thought about that, too, and while the red used in the icon is exactly 
`NegativeText`, the blue in the current icon is darker and has a less vibrant 
hue than `ButtonFocus`, so I'm not quite comfortable with using that for the 
blue color. Do we have this darker blue as a CSS color that we can use in this 
way? I see this dark blue is also used in the `channelmixer` icon, which has 
its colors hardcoded as well. I also don't think it would make sense to only 
use stylesheet colors for only one of these two colors.
  
  Btw, in the relevant HIG page 
(https://hig.kde.org/style/icon.html#action-and-status-icons) the color 
`ColorScheme-ButtonFocus` in the page you linked is called 
`ColorScheme-Highlight` and there are other anme differences, too. Is one of 
these inaccurate, or do they both work?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Björn Feber]

GB_2 added a comment.


  Maybe instead of hardcoding the blue and red colors you can use the 
stylesheet colors `ButtonFocus` and `NegativeText`: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 marked 4 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 63652.
trickyricky26 added a comment.


  - Fix stylesheet ids

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23116?vs=63626&id=63652

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Not having `id="current-color-scheme"` causes stylesheets to not work 
correctly.

INLINE COMMENTS

> depth16to8.svg:1
> -http://www.w3.org/2000/svg"; viewBox="0 0 22 22">
> -  
> -

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  `FIXED-IN: ` refers to the next release (i.e. the one that this fix will make 
it into). The latest released version of KDE Frameworks is 5.61, so the next 
one is 5.62.
  
  I imagine the Digikam Windows build scoops up all the relevant assets liek 
icons and includes them in the installed app. If not, then the breeze-icons 
framework actually gets installed on Windows somewhere. Either way, you don't 
need to do anything else.
  
  LGTM! All good, @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 added a comment.


  I am not quite sure of the version for the FIXED-IN tag.
  
  Also, this bug was reported in digikam running on Windows 10, are there any 
additional steps necessary to get this change from breeze-icons to the digikam 
Windows build?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns