D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
cullmann added a comment. If the highlighting still is OK after removing them, sure, but it looks like the language wanted explicitly have different colors for stuff using the same default style. Perhaps one could use some of the new default styles in some places. And I would always update the version, to allow people to update properly. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
jpoelen added a comment. If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
cullmann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks. Removing hardcoded colors would also be nice :-) REPOSITORY R216 Syntax Highlighting BRANCH gettext (branched from master) REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D23135: Gettext: fix "previous untranslated string" and other improvements/fixes
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix #| (previous untranslated string) - fix hexadecimal entity - fix html tag in `a < b` - use rather than for auto-completion - string without " at the end of the line is an error - # followed by something other than " |:.," is an extension REPOSITORY R216 Syntax Highlighting BRANCH gettext (branched from master) REVISION DETAIL https://phabricator.kde.org/D23135 AFFECTED FILES autotests/folding/highlight.po.fold autotests/html/highlight.po.html autotests/input/highlight.po autotests/reference/highlight.po.ref data/syntax/gettext.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
