D23171: Avoid enabling kcrash if it's only included via a plugin

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R285:e64b8314e201: Avoid enabling kcrash if its only 
included via a plugin (authored by davidedmundson).

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23171?vs=63787=63790

REVISION DETAIL
  https://phabricator.kde.org/D23171

AFFECTED FILES
  src/kcrash.cpp

To: davidedmundson, mart
Cc: mart, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  the logic is awesome, the checking with the static is not super pretty but 
saves significantly useless checks

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23171

To: davidedmundson, mart
Cc: mart, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

[David Edmundson]

davidedmundson added a comment.


  Alternatively we could just kill the Q_COREAPP_STARTUP_FUNCTION as most apps 
already explicitly call KCrash::initialize() to get round distros compiling 
with link-as-needed?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D23171

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If a Qt app happens to load our plasma-integration plugin it shouldn't
  change how bug reporting works.
  
  There's no point showing drkonqi if there's not an
  appropriate KDE product.
  
  Worse, our crash handling can interfere with that processes own signal
  handling.
  
  This patch is effectively a copy of
  02b523bad09aab062355e46771889b0f3709692f 
 in 
kxmlgui for enabling auto-
  accelerators only if the lib is linked directly.
  
  BUG: 401637

TEST PLAN
  Changed the crashtest app in drkonqi to not directly link - didn't get drkonqi
  Re-enabled linking. Got drkonqi

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23171

AFFECTED FILES
  src/kcrash.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns