D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25063

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:e8f558f8b2c7: Deprecate KAboutData::fromPluginMetaData, 
now there is KAboutPluginDialog (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25063?vs=69017=70259#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25063?vs=69017=70259

REVISION DETAIL
  https://phabricator.kde.org/D25063

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kaboutdata.h:478
> + * @deprecated Since 5.65, use KAboutPluginDialog to show info about a 
> plugin
> + * instead of KAboutApplicationDialogso, with the latter having had been 
> the
> + * only known need for this conversion.

typo: "Dialogso" -> "Dialog"

REPOSITORY
  R244 KCoreAddons

BRANCH
  deprecateaboutdatafromPluginMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25063

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Depends on D25058 

REPOSITORY
  R244 KCoreAddons

BRANCH
  deprecateaboutdatafromPluginMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25063

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns