D27357: Fix infinite recursion in xscreensaver plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R274:3dae871e6b89: Fix infinite recursion in xscreensaver plugin (authored by alnikiforov, committed by broulik). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a comment. Sorry, I just returned from vacation. I'll merge this on Monday (since Frameworks tagging is tomorrow) so we'll get another month worth of testing. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson,

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov added a comment. Could you please merge this change? Or is something stopping from merging it? REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack,

D27357: Fix infinite recursion in xscreensaver plugin

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a reviewer: Frameworks. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov added a comment. In D27357#610605 , @broulik wrote: > Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine. > However, I don't know if that won't

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a comment. Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine. However, I don't know if that won't indirectly trigger it if the session was idle? Maybe we need to check if the session was idle

D27357: Fix infinite recursion in xscreensaver plugin

alnikiforov created this revision. alnikiforov added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alnikiforov requested review of this revision. REVISION SUMMARY Follow up for D27279