D27396: support icon.width/height

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in TabButton.qml:61 > @mart Why did you remove the color here? Seems unrelated to size? > This broke things e.g. with Breeze Dark (as can be seen e.g. with the > weather widget's tab buttons (use BBC service to have tabs).

D27396: support icon.width/height

kossebau added inline comments. INLINE COMMENTS > TabButton.qml:61 > opacity: enabled || control.highlighted || control.checked ? 1 : > 0.4 > -color: control.activeFocus && !control.down ? > theme.highlightedTextColor : theme.buttonTextColor >

D27396: support icon.width/height

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3de1c2462eda: support icon.width/height (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27396?vs=75677=75678 REVISION DETAIL

D27396: support icon.width/height

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/iconSize REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27396: support icon.width/height

mart updated this revision to Diff 75677. mart added a comment. - don't expose externally default size REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27396?vs=75675=75677 BRANCH phab/iconSize REVISION DETAIL

D27396: support icon.width/height

mart updated this revision to Diff 75675. mart added a comment. - default icon sizes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27396?vs=75672=75675 BRANCH phab/iconSize REVISION DETAIL https://phabricator.kde.org/D27396

D27396: support icon.width/height

mart added a comment. In D27396#611425 , @broulik wrote: > Don't we want to set a default? I keep seeing people hardcoding `icon.width` all over the place when they used PC3 and I want that to stop then should be i think smallMedium size

D27396: support icon.width/height

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27396: support icon.width/height

broulik added a comment. Don't we want to set a default? I keep seeing people hardcoding `icon.width` all over the place when they used PC3 and I want that to stop REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma Cc:

D27396: support icon.width/height

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY support the icon size hint of the control. Reinstate it in ToolButton and add the support