D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 77407.
niccolove added a comment.


  Changed filename to heading

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=77272=77407

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Nathaniel Graham]

ngraham added a comment.


  The actual component is called `PlasmoidHeading`, but this file is 
`PlasmoisHeader`. Maybe they should match?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 77272.
niccolove added a comment.


  Renamed file as plasmoidheader and used scour

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=76562=77272

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/plasmoidheader.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Nathaniel Graham]

ngraham added a comment.


  Maybe run it through an SVG optimizer; See 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Scour

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 76562.
niccolove added a comment.


  Hardcoded colors

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=76378=76562

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove added a dependent revision: D27695: WIP: Create a new TopArea element 
using widgets/toparea svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 76378.
niccolove added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=76376=76378

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 76376.
niccolove added a comment.


  Added toparea margins

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=75824=76376

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  plasma-framework.categories
  src/CMakeLists.txt
  src/declarativeimports/core/private/DefaultToolTip.qml
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Title.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/toparea.svg
  src/plasma/CMakeLists.txt
  src/plasma/pluginloader.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasmaquick/CMakeLists.txt
  src/scriptengines/qml/CMakeLists.txt
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h
  tests/components/radiobutton3.qml

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove added a comment.


  In D27444#614762 , @mart wrote:
  
  > - i would provide one single svg with top and bottom areas so one can use 
something like that as a footer as well (and probably a frame that has nothing 
rounded)
  > - if you have a top panel the top won't be rounded, we need a way to know 
this.. perhaps with plasmoid.location... not sure yet
  
  
  Regarding these two points:
  
  - This patch already provides a single svg with top and bottom areas
  - When there is a top panel, the idea is to place the top area at the bottom, 
like Kickoff currently dynamically places the user avatar and name on the side 
far from the panel. The toparea should never touch the panel, imo.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Marco Martin]

mart added a comment.


  i also wonder if the normal "toolbar2 element already existing can be used..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Marco Martin]

mart added a comment.


  some considerations:
  
  - this toparea will need to "overflow" its parent for the exact distance 
needed to perfectly fuse with the background, and has to work with both dialogs 
and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the 
exact same shape) for this reason also fallback should be disabled and be used 
only in themes that directly provide it.
  - we need 2 margins here: how much we want to overflow, which i would say 
should be the actual framesvg margins, so one doesn't have to *ever* access the 
dialog instance or the applet background, and the margins we want to actually 
use as padding for its contents. we can decide either to put both as hints in 
the svg, or to use units.smallspacing as padding for the contents and be happy 
with it
  - i would provide one single svg with top and bottom areas so one can use 
something like that as a footer as well (and probably a frame that has nothing 
rounded)
  - if you have a top panel the top won't be rounded, we need a way to know 
this.. perhaps with plasmoid.location... not sure yet

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Nathaniel Graham]

ngraham added a comment.


  Oops, you're right! My mistake, sorry.
  
  Will resume the review.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove added a comment.


  In D27444#612582 , @ngraham wrote:
  
  > This will need CMake changes to actually install it.
  
  
  Isn't this automatically done by the glob?
  
FILE(GLOB widgets widgets/*.svg)
plasma_install_desktoptheme_svgs(default SUBPATH widgets FILES ${widgets})

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove updated this revision to Diff 75824.
niccolove added a comment.


  Remove hardcoded values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=75796=75824

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Nathaniel Graham]

ngraham added a comment.


  This will need CMake changes to actually install it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> toparea.svg:727
> + id="rect4138-7"
> + 
> style="color:#eff0f1;opacity:0.75;fill:currentColor;fill-opacity:0.6;stroke:none"
>  />
> +

Are these supposed to have hardcoded colors?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove added a dependent revision: D27189: Created a top area based on 
widgets/toparea.svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove added reviewers: VDG, ngraham, ndavis.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Adds top area for D27189 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns