D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-14 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7d80f01c3162: WIP: Create a new TopArea element using widgets/toparea svg (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-13 Thread Nathaniel Graham
ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent work. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-13 Thread Niccolò Venerandi
niccolove added a comment. Works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-13 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77588. niccolove added a comment. Fixed inset REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77482=77588 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-12 Thread Niccolò Venerandi
niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-12 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77482. niccolove added a comment. Added PlasmoidHeading to qmldir REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77418=77482 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. You need to add it to the file `src/declarativeimports/plasmaextracomponents/qml/qmldir` or else it doesn't get installed in a way that anything can see it. REPOSITORY R242

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Nathaniel Graham
ngraham added a dependent revision: D27979: [WIP] Add top area to notifications. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77418. niccolove added a comment. Trailing spaces REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77408=77418 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77408. niccolove added a comment. use heading instead of header REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77405=77408 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77405. niccolove added a comment. bottomPadding rather than bottomMargin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77404=77405 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77404. niccolove added a comment. Missed a PlasmoidHeading. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77402=77404 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77402. niccolove added a comment. Local is not a type REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77271=77402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Nathaniel Graham
ngraham added a comment. Watch your whitespace. This new file is full of cases where there are spaces on on blank lines or trailing spaces. `git show HEAD` will show you for the latest commit: F8167726: Screenshot_20200309_114735.png Also

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77271. niccolove added a comment. documentation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77266=77271 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77266. niccolove added a comment. using =| REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77263=77266 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED FILES

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > PlasmoidHeading.qml:52 > +enabledBorders: { > +var borders = new Array() > +borders.push('LeftBorder') this can be an int and instead of borders.push('LeftBorder') borders |= PlasmaCore.FrameSvg.LeftBorder REPOSITORY

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77263. niccolove added a comment. Correct padding and borders REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76947=77263 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Marco Martin
mart added a comment. In D27695#621985 , @niccolove wrote: > - Is code on line 51 fine? Lines are a bit long there yeah, is fine.. unfortunately sunch superlong lines end up being very common in QML REPOSITORY R242 Plasma Framework

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi
niccolove added a comment. Two questions: - I know we should not assume it's a Layout, but margins should be defined inside the file as they compensate the inset; is it possible to both define them with Layout and anchors, or something that would work with both? - Is code on line 51

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76947. niccolove added a comment. Moved TopArea to PlasmoidHeading and various fixes in it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76862=76947 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Marco Martin
mart added a comment. I would call the component PlasmoidHeading, to make clear it's only for use in plasmoids INLINE COMMENTS > TopArea.qml:28 > + > +property bool flipped: false > + enum Location { Header, Footer (maybe a middle as well?) } property Location

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76862. niccolove added a comment. Replace test with widgets/toparea REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76860=76862 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove added a comment. In D27695#621305 , @davidedmundson wrote: > PC3 is designed to be only a theme for QQC2 That's why I moved it to plasmaextracomponent with the last commit, actually REPOSITORY R242 Plasma Framework (Library)

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread David Edmundson
davidedmundson added a comment. PC3 is designed to be only a theme for QQC2 For new API this is the wrong place. INLINE COMMENTS > TopArea.qml:44 > +id: topAreaSvg > +imagePath: "test" > +prefix: flipped? 'flipped' : '' test? REPOSITORY R242 Plasma Framework

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76860. niccolove added a comment. Moved the file to Extra components REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76822=76860 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76822. niccolove added a comment. Width is fill anyway, no need to calculate it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76572=76822 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76572. niccolove marked an inline comment as done. niccolove added a comment. Fixed margin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76534=76572 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Nathaniel Graham
ngraham added a dependent revision: D27697: WIP: Added top area to notification header. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove marked an inline comment as done. niccolove added inline comments. INLINE COMMENTS > ahiemstra wrote in TopArea.qml:40 > This conditional is wrong. The syntax is `condition ? true_case : false_case` > so you want to write `flipped ? -topAreaSvg.margins.top : >

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76534. niccolove added a comment. Fixed conditionals REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76531=76534 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > TopArea.qml:40 > +rightInset: -topAreaSvg.margins.right > +topInset: -topAreaSvg.margins.bottom ? flipped : -topAreaSvg.margins.top > +bottomInset: -topAreaSvg.margins.bottom ? flipped : > -topAreaSvg.margins.top This conditional

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76531. niccolove added a comment. Fixed svg path REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76528=76531 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76528. niccolove added a comment. Added licence REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76527=76528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY This creates a new component that uses the widgets/toparea svg. First time I try to add something to