bport updated this revision to Diff 79780.
bport added a comment.
Rename state probe to data (because can be useful for more than only state
probe)
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28460?vs=79772=79780
REVISION DETAIL
bport marked 10 inline comments as done.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
bport updated this revision to Diff 79772.
bport added a comment.
ervin feedback
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28460?vs=79496=79772
REVISION DETAIL
https://phabricator.kde.org/D28460
AFFECTED FILES
src/CMakeLists.txt
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmoduleloader.cpp:161
> +if (!mod.service() || mod.service()->noDisplay() ||
> mod.library().isEmpty())
> +{
> +return true;
Curly brace
bport updated this revision to Diff 79496.
bport added a comment.
Take in consideration feedbacks
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28460?vs=78969=79496
REVISION DETAIL
https://phabricator.kde.org/D28460
AFFECTED FILES
broulik added inline comments.
INLINE COMMENTS
> kcmodulestateprobe.h:21
> +
> +#ifndef KCMODULEDEFAULT_H
> +#define KCMODULEDEFAULT_H
`KCMODULESTATEPROBE_H`
> kcmodulestateprobe.h:25
> +#include
> +#include
> +#include
Forward-declare
> kcmodulestateprobe.h:39
> +virtual bool
broulik added inline comments.
INLINE COMMENTS
> kcmoduleloader.cpp:165
> +
> +if (!mod.library().isEmpty()) {
> +QString error;
Use an early return here
> kcmoduleloader.cpp:176
> +if (factory) {
> +auto p = factory->create(nullptr, args2);
> +if
bport added a dependent revision: D28461: In sidebar mode show if a module is
in default state or not.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
bport created this revision.
bport added reviewers: Plasma, ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.
REVISION SUMMARY
This class will allow to get state of a module without loading the UI.
REPOSITORY
