ngraham accepted this revision.
ngraham added inline comments.
INLINE COMMENTS
> thumbnail.cpp:724
> // no cached version is available, a new thumbnail must be
> created
> -
> QSaveFile thumbnailfile(thumbPath.absoluteFilePath(thumbName));
There are extra spaces on
ivan accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To: marcingu, ivan, broulik, #dolphin
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio,
fprice, LeGast00n,
marcingu marked an inline comment as done.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To: marcingu, ivan, broulik, #dolphin
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio,
fprice, LeGast00n, cblack, fbampaloukas, alexde,
marcingu updated this revision to Diff 79986.
marcingu added a comment.
Review fixes
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28745?vs=79826=79986
REVISION DETAIL
https://phabricator.kde.org/D28745
AFFECTED FILES
thumbnail/thumbnail.cpp
To:
ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> thumbnail.cpp:730
> +const auto thumbRootMount = mountsList.findByPath(thumbRoot);
> +std::copy_if(mountsList.begin(), mountsList.end(),
>
ngraham retitled this revision from "Skipping catching of thumbnails on
encrytped filesystems" to "Skipping catching of thumbnails on encrypted
filesystems".
ngraham edited the summary of this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28745
To:
