D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-15 Thread Méven Car
meven removed a dependent revision: D29407: ScreenshotEffect: Use Service 
Property to authorize screenshot without confirmation.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-05 Thread Méven Car
meven abandoned this revision.
meven added a comment.


  This not necessary, spectacle should have its executable in its Exec desktop 
entry.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-05 Thread Méven Car
meven added a comment.


  In D29406#663112 , @apol wrote:
  
  > > If I understand correctly, it is necessary to use dbus spectacle in this 
case, so that dbus can manage the application instance and make sure we end up 
with only one, whether we launch the app, use a shortcut or launch from command 
line.
  >
  > I don't think that's a good reason. We have lots of applications that do 
that without having to be launched by dbus: plasmashell, krunner, yakuake, etc. 
It's done by using KDBusService.
  
  
  I didn't know about this, so did perhaps @davidedmundson in 
https://phabricator.kde.org/D19153#417025
  I guess spectacle should use `KDBusService(KDBusService::Unique` but it has 
always been in multiple instance since it was Dbus enabled 
09cd11881d828da35c46c48da79f2d988e6a78cc 
 and 
this require some refactoring unfortunately.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment.


  > If I understand correctly, it is necessary to use dbus spectacle in this 
case, so that dbus can manage the application instance and make sure we end up 
with only one, whether we launch the app, use a shortcut or launch from command 
line.
  
  I don't think that's a good reason. We have lots of applications that do that 
without having to be launched by dbus: plasmashell, krunner, yakuake, etc. It's 
done by using KDBusService.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven added a comment.


  In D29406#662932 , @apol wrote:
  
  > This should be documented somewhere, as is it's really confusing.
  
  
  I am not sure where to document this, but agrees this is needed.
  Will look on existing documentation to find the place.
  (Maybe add a comment in the application.desktop file)
  
  > I'm not sure it wouldn't be better to have spectacle launched again there 
instead of going through dbus (which is a change I admittedly don't understand 
very well).
  
  If I understand correctly, it is necessary to use `dbus spectacle`in this 
case, so that dbus can manage the application instance and make sure we end up 
with only one, whether we launch the app, use a shortcut or launch from command 
line.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven added a dependent revision: D29407: ScreenshotEffect: Use Service 
Property to authorize screenshot without confirmation.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment.


  This should be documented somewhere, as is it's really confusing.
  
  I'm not sure it wouldn't be better to have spectacle launched again there 
instead of going through dbus (which is a change I admittedly don't understand 
very well).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Méven Car
meven created this revision.
meven added reviewers: Frameworks, davidedmundson, apol, bport.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Sometimes Exec entries are replaced by qdbus invocation such as in D19225 

  Add a property X-KDE-Original-Executable to allow to specify the original 
Exec path.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29406

AFFECTED FILES
  src/services/application.desktop

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns