This revision was automatically updated to reflect the committed changes.
Closed by commit R241:391351a6be0e: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT
(authored by kossebau).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29708?vs=82730=82806
REVISION DETAIL
dfaure added a comment.
> there are lots of KRun::run* usages in non-deprecated API sadly in KIO :(
OK, I'll fix that.
REPOSITORY
R241 KIO
BRANCH
excludedeprecated
REVISION DETAIL
https://phabricator.kde.org/D29708
To: kossebau, #frameworks, dfaure, meven, ahmadsamir
Cc:
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Great stuff, this much less cleanup will be needed for KF6 !
INLINE COMMENTS
> global.cpp:99
>
> +#if KIOCORE_BUILD_DEPRECATED_SINCE(3, 4)
> KIOCORE_EXPORT QTime
kossebau added a comment.
@dfaure So far I had no idea how to introduce a simple variant of the
deprecation macros to support just disabling latest. For one would this make
things more complex as there would be yet another approach. And things would be
also become a bit unreliable on the
kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure, meven, ahmadsamir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Not all versions of the past will work as value,