D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. In D29805#674225 , @pino wrote: > In D29805#674218 , @meven wrote: > > > In D29805#674206 , @pino wrote: > > > > > In

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. In D29805#674218 , @meven wrote: > In D29805#674206 , @pino wrote: > > > In D29805#674205 , @meven wrote: > > > > > In

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. In D29805#674206 , @pino wrote: > In D29805#674205 , @meven wrote: > > > In D29805#674204 , @pino wrote: > > > > > > FIXED-IN:

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. In D29805#674205 , @meven wrote: > In D29805#674204 , @pino wrote: > > > > FIXED-IN: 20.08 > > > > still for 20.08... > > > Yes kio-extra is released with KDE

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. In D29805#674204 , @pino wrote: > > FIXED-IN: 20.08 > > still for 20.08... Yes kio-extra is released with KDE Applications REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. > FIXED-IN: 20.08 still for 20.08... REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven updated this revision to Diff 83177. meven marked an inline comment as done. meven added a comment. Remove brackets REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83018=83177 BRANCH arcpatch-D29805 REVISION DETAIL

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added inline comments. INLINE COMMENTS > meven wrote in djvucreator.cpp:52-54 > I'd like to use instead the Framework coding style to improve homogenizing > coding styles. > https://community.kde.org/Policies/Frameworks_Coding_Style#Braces this code does not follow that style, so please

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in djvucreator.cpp:52-54 > extra brackets I'd like to use instead the Framework coding style to improve homogenizing coding styles.

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

pino added a comment. please target `release/20.04` for this fix, thanks INLINE COMMENTS > djvucreator.cpp:52-54 > + if (QStandardPaths::findExecutable(QStringLiteral("ddjvu")).isEmpty()) { > + return false; > + } extra brackets REPOSITORY R320 KIO Extras REVISION DETAIL

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. ping @pino REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven added a comment. @pino ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven, #frameworks, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven updated this revision to Diff 83018. meven added a comment. fix indentation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29805?vs=83014=83018 BRANCH arcpatch-D29805 REVISION DETAIL https://phabricator.kde.org/D29805 AFFECTED FILES

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

meven retitled this revision from "Thumbnail djvu: avoid to exit(1) when it should not" to "Thumbnail djvu: Avoid a crash when djvu is not installed". meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29805 To: meven,