D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven added a comment.


  In D29805#674225 , @pino wrote:
  
  > In D29805#674218 , @meven wrote:
  >
  > > In D29805#674206 , @pino wrote:
  > >
  > > > In D29805#674205 , @meven 
wrote:
  > > >
  > > > > In D29805#674204 , @pino 
wrote:
  > > > >
  > > > > > > FIXED-IN: 20.08
  > > > > >
  > > > > > still for 20.08...
  > > > >
  > > > >
  > > > > Yes kio-extra is released with KDE  Applications
  > > >
  > > >
  > > > Yes, I know. Asked to land this fix instead to `release/20.04`, and 
thus change the commit message accordingly.
  > >
  > >
  > > Please be explicit when you comment, no one could deduce what you meant.
  >
  >
  > I wrote it **two** times to land this on the stable branch: the first time 
when I explained why the initial patch was not correct and what the problem 
actually was (with hints on short term and long term fixes), and earlier today 
when I wrote:
  >
  > In D29805#674185 , @pino wrote:
  >
  > > please target `release/20.04` for this fix, thanks
  >
  >
  > There is no need to "deduce" anything, just read what I wrote, thanks.
  >
  > > If this is ready approve and add a comment "land to 20.04".
  >
  > The commit message still says "20.08", so not yet.
  
  
  That's a detail once it is accepted it is trivial to edit...
  Usually this is not required.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Pino Toscano 
pino added a comment.


  In D29805#674218 , @meven wrote:
  
  > In D29805#674206 , @pino wrote:
  >
  > > In D29805#674205 , @meven 
wrote:
  > >
  > > > In D29805#674204 , @pino 
wrote:
  > > >
  > > > > > FIXED-IN: 20.08
  > > > >
  > > > > still for 20.08...
  > > >
  > > >
  > > > Yes kio-extra is released with KDE  Applications
  > >
  > >
  > > Yes, I know. Asked to land this fix instead to `release/20.04`, and thus 
change the commit message accordingly.
  >
  >
  > Please be explicit when you comment, no one could deduce what you meant.
  
  
  I wrote it **two** times to land this on the stable branch: the first time 
when I explained why the initial patch was not correct and what the problem 
actually was (with hints on short term and long term fixes), and earlier today 
when I wrote:
  
  In D29805#674185 , @pino wrote:
  
  > please target `release/20.04` for this fix, thanks
  
  
  There is no need to "deduce" anything, just read what I wrote, thanks.
  
  > If this is ready approve and add a comment "land to 20.04".
  
  The commit message still says "20.08", so not yet.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven added a comment.


  In D29805#674206 , @pino wrote:
  
  > In D29805#674205 , @meven wrote:
  >
  > > In D29805#674204 , @pino wrote:
  > >
  > > > > FIXED-IN: 20.08
  > > >
  > > > still for 20.08...
  > >
  > >
  > > Yes kio-extra is released with KDE  Applications
  >
  >
  > Yes, I know. Asked to land this fix instead to `release/20.04`, and thus 
change the commit message accordingly.
  
  
  Please be explicit when you comment, no one could deduce what you meant.
  
  If this is ready approve and add a comment "land to 20.04".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Pino Toscano 
pino added a comment.


  In D29805#674205 , @meven wrote:
  
  > In D29805#674204 , @pino wrote:
  >
  > > > FIXED-IN: 20.08
  > >
  > > still for 20.08...
  >
  >
  > Yes kio-extra is released with KDE  Applications
  
  
  Yes, I know. Asked to land this fix instead to `release/20.04`, and thus 
change the commit message accordingly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven added a comment.


  In D29805#674204 , @pino wrote:
  
  > > FIXED-IN: 20.08
  >
  > still for 20.08...
  
  
  Yes kio-extra is released with KDE  Applications

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Pino Toscano 
pino added a comment.


  > FIXED-IN: 20.08
  
  still for 20.08...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven marked 2 inline comments as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven updated this revision to Diff 83177.
meven marked an inline comment as done.
meven added a comment.


  Remove brackets

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29805?vs=83018=83177

BRANCH
  arcpatch-D29805

REVISION DETAIL
  https://phabricator.kde.org/D29805

AFFECTED FILES
  thumbnail/djvucreator.cpp

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Pino Toscano 
pino added inline comments.

INLINE COMMENTS

> meven wrote in djvucreator.cpp:52-54
> I'd like to use instead the Framework coding style to improve homogenizing 
> coding styles.
> https://community.kde.org/Policies/Frameworks_Coding_Style#Braces

this code does not follow that style, so please keep new changes coherent with 
the existing style

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Méven Car 
meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> pino wrote in djvucreator.cpp:52-54
> extra brackets

I'd like to use instead the Framework coding style to improve homogenizing 
coding styles.
https://community.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-30 Thread Pino Toscano 
pino added a comment.


  please target `release/20.04` for this fix, thanks

INLINE COMMENTS

> djvucreator.cpp:52-54
> +  if (QStandardPaths::findExecutable(QStringLiteral("ddjvu")).isEmpty()) {
> + return false;
> +  }

extra brackets

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-29 Thread Méven Car 
meven added a comment.


  ping @pino

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-22 Thread Méven Car 
meven added a comment.


  @pino ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-17 Thread Méven Car 
meven updated this revision to Diff 83018.
meven added a comment.


  fix indentation

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29805?vs=83014=83018

BRANCH
  arcpatch-D29805

REVISION DETAIL
  https://phabricator.kde.org/D29805

AFFECTED FILES
  thumbnail/djvucreator.cpp

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29805: Thumbnail djvu: Avoid a crash when djvu is not installed

2020-05-17 Thread Méven Car 
meven retitled this revision from "Thumbnail djvu: avoid to exit(1) when it 
should not" to "Thumbnail djvu: Avoid a crash when djvu is not installed".
meven edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29805

To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, 
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov