D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-29 Thread Méven Car 
meven abandoned this revision.
meven added a comment.


  Moved to https://invent.kde.org/network/kio-extras/-/merge_requests/2

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29806

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-18 Thread Méven Car 
meven planned changes to this revision.
meven added a comment.


  Will probably send to gitlab ;)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29806

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-18 Thread Nathaniel Graham 
ngraham added a comment.


  Haha the "before" image is hilarious!

INLINE COMMENTS

> thumbnail.cpp:415
> +} else
> +if ((image.size().height() > imageTargetSize.height()) && 
> (imageTargetSize.height() != 0)) {
> +scaling = float(imageTargetSize.height()) / 
> float(image.size().height());

Is this an `else if (...) {` or an `else { if (...) {`

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29806

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-17 Thread Méven Car 
meven edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29806

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-17 Thread Méven Car 
meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 419566
  FIXED-IN: 20.08

TEST PLAN
  Before:
  
  After

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29806

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov