D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
This revision was automatically updated to reflect the committed changes. Closed by commit R288:66510d55dbe0: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3439?vs=14669=15154#toc REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=14669=15154 REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt To: kossebau, #frameworks, ochurlaud Cc: shumski
D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 14669. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8792=14669 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Updated, 37 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 8792. kossebau added a comment. update to latest ECMAddQch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8589=8792 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Updated, 36 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 8589. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8488=8589 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Updated] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau added a dependency: D2854: New: ECMAddQCH, for generating qch & doxygen tag files. REVISION DETAIL https://phabricator.kde.org/D3439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Updated, 32 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 8488. kossebau added a comment. Use new KDE_INSTALL_FULL_QTQCHDIR CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8357=8488 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Commented On] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
shumski added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:82 > Imagine another project with a lib MyLib linking against KJobWidgets (in the > public interface). For MyLib also a QCH file should be created. To create > proper links from the QCH file for MyLib into the QCH file of KJobWidgets > (via qthelp:// urls), doxygen/the qt tools need to have access to some > information. This information is bound to the KF5JobWidgets_QCH target (see > https://phabricator.kde.org/D2854). > By exporting the target here and including it into KF5JobWidgetsConfig.cmake, > this information then is automatically available to the ecm_add_qch call with > MyLib and passing just the target name in the LINK_QCH argument. Allright, make sense. REVISION DETAIL https://phabricator.kde.org/D3439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Commented On] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau added inline comments. INLINE COMMENTS > shumski wrote in CMakeLists.txt:82 > I wonder about the reasoning behind the existence of this export, and > installation of it... Imagine another project with a lib MyLib linking against KJobWidgets (in the public interface). For MyLib also a QCH file should be created. To create proper links from the QCH file for MyLib into the QCH file of KJobWidgets (via qthelp:// urls), doxygen/the qt tools need to have access to some information. This information is bound to the KF5JobWidgets_QCH target (see https://phabricator.kde.org/D2854). By exporting the target here and including it into KF5JobWidgetsConfig.cmake, this information then is automatically available to the ecm_add_qch call with MyLib and passing just the target name in the LINK_QCH argument. REVISION DETAIL https://phabricator.kde.org/D3439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Changed Subscribers] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
shumski added inline comments.
INLINE COMMENTS
> CMakeLists.txt:82
>
> +ecm_install_qch_export(
> +TARGETS KF5JobWidgets_QCH
I wonder about the reasoning behind the existence of this export, and
installation of it...
> CMakeLists.txt:98
> +TAGFILE_INSTALL_DESTINATION ${KDE_INSTALL_FULL_DATADIR}/qch
> +QCH_INSTALL_DESTINATION ${KDE_INSTALL_FULL_DATADIR}/qch
> +)
Is this really the right place?
REVISION DETAIL
https://phabricator.kde.org/D3439
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #frameworks, ochurlaud
Cc: shumski
[Differential] [Request, 32 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5JobWidgets.qch created by this: https://share.kde.org/index.php/s/UhVPFAy2cTb8cBL BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud
