D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-20 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.
Closed by commit R263:951bc8a9b3c9: API dox: add notes to KActionCollection 
about QAction ownership handling (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6279?vs=15611=15637#toc

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6279?vs=15611=15637

REVISION DETAIL
  https://phabricator.kde.org/D6279

AFFECTED FILES
  src/kactioncollection.h

To: kossebau, #frameworks, dfaure
Cc: apol

D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-20 Thread David Faure 
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kactioncollection.h:325
>   *
> + * The ownership of the action object is not transferred. If the action 
> is destroyed
> + * it will be removed automatically from the KActionCollection.

I would add a newline after the '.'
Otherwise it looks like the second sentence is related to the first, but it's 
not really.

> kactioncollection.h:341
>   *
> + * The ownership of the action objects is not transferred. If the action 
> is destroyed
> + * it will be removed automatically from the KActionCollection.

same

REPOSITORY
  R263 KXmlGui

BRANCH
  apidoxQActionOwnership

REVISION DETAIL
  https://phabricator.kde.org/D6279

To: kossebau, #frameworks, dfaure
Cc: apol

D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-19 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 15611.
kossebau added a comment.


  note auto-removal on destroying the action

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6279?vs=15594=15611

BRANCH
  apidoxQActionOwnership

REVISION DETAIL
  https://phabricator.kde.org/D6279

AFFECTED FILES
  src/kactioncollection.h

To: kossebau, #frameworks, dfaure
Cc: apol

D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-19 Thread Aleix Pol Gonzalez 
apol added a comment.


  Then it would make sense to say what happens if an action is destroyed as 
well, no?
  Something like `If an action is destroyed will be removed automatically from 
the KActionCollection`. Which is what I think it happens but didn't really 
check.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D6279

To: kossebau, #frameworks, dfaure
Cc: apol

D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-19 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R263 KXmlGui

BRANCH
  apidoxQActionOwnership

REVISION DETAIL
  https://phabricator.kde.org/D6279

AFFECTED FILES
  src/kactioncollection.h

To: kossebau, #frameworks, dfaure