D6774: Fix labels of DeleteFile/RenameFile actions

2017-08-09 Thread Elvis Angelaccio 
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:b0a481e66905: Fix labels of DeleteFile/RenameFile actions 
(authored by elvisangelaccio).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6774?vs=17901=17942

REVISION DETAIL
  https://phabricator.kde.org/D6774

AFFECTED FILES
  src/kstandardaction.h
  src/kstandardaction_p.h

To: elvisangelaccio, #frameworks, dfaure
Cc: dfaure, cfeck

D6774: Fix labels of DeleteFile/RenameFile actions

2017-08-08 Thread Elvis Angelaccio 
elvisangelaccio updated this revision to Diff 17901.
elvisangelaccio added a comment.


  - Add documentation

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6774?vs=16883=17901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6774

AFFECTED FILES
  src/kstandardaction.h
  src/kstandardaction_p.h

To: elvisangelaccio, #frameworks, dfaure
Cc: dfaure, cfeck

D6774: Fix labels of DeleteFile/RenameFile actions

2017-08-08 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Is it possible to document somewhere that DeleteFile/RenameFile can be about 
files and folders?
  
  (I wonder if they shouldn't have been just called Delete and Rename, in 
fact... it sounds like they could apply to any other type of object too, the 
icon looks generic)

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6774

To: elvisangelaccio, #frameworks, dfaure
Cc: dfaure, cfeck

D6774: Fix labels of DeleteFile/RenameFile actions

2017-08-07 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Ping?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D6774

To: elvisangelaccio, #frameworks
Cc: cfeck

D6774: Fix labels of DeleteFile/RenameFile actions

2017-08-02 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  In https://phabricator.kde.org/D6774#131083, @cfeck wrote:
  
  > Interesting. When I RMB-click on a folder in Dolphin, I indeed see "Delete 
File" in the context menu, but I do not see "Rename File", but "Rename ..." 
instead. Does Dolphin not use standard actions consistently?
  
  
  Correct, the RenameFile standard action is quite new (@since 5.25) and 
dolphin doesn't use it yet (see https://phabricator.kde.org/D6777, which 
depends on this patch).

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D6774

To: elvisangelaccio, #frameworks
Cc: cfeck

D6774: Fix labels of DeleteFile/RenameFile actions

2017-08-01 Thread Christoph Feck 
cfeck added a comment.


  Interesting. When I RMB-click on a folder in Dolphin, I indeed see "Delete 
File" in the context menu, but I do not see "Rename File", but "Rename ..." 
instead. Does Dolphin not use standard actions consistently?
  
  +1 from my side.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D6774

To: elvisangelaccio, #frameworks
Cc: cfeck

D6774: Fix labels of DeleteFile/RenameFile actions

2017-07-19 Thread Elvis Angelaccio 
elvisangelaccio added a dependent revision: D6777: Port to 
KStandardAction::MoveToTrash.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D6774

To: elvisangelaccio, #frameworks

D6774: Fix labels of DeleteFile/RenameFile actions

2017-07-18 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  These actions can be applied also to folders, so their user-visible
  labels should not explicitly mention "File".
  
  BUG: 382450

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6774

AFFECTED FILES
  src/kstandardaction_p.h

To: elvisangelaccio, #frameworks