D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2020-04-12 Thread Shlomi Fish
shlomif abandoned this revision. shlomif added a comment. Closing then. I don't have any immediate plans for reworking this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8274 To: shlomif, dfaure Cc: kde-frameworks-devel, ngraham, rkflx, dfaure, bcooksley,

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2020-04-12 Thread David Faure
dfaure added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @shlomif any plans on redoing this another way? Otherwise can you close the review request, to clean up dashboards? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8274

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-12-02 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Yes, emulating `cp -a` is on purpose. A flag for a "deep copy" might be useful, but not changing the default behaviour. And I definitely hope this patch breaks jobtest

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-10-13 Thread Henrik Fehlauer
rkflx added subscribers: dfaure, rkflx. rkflx added a comment. Unfortunately, this two year old patch does not apply for me anymore to the current git master (while it did apply to v5.15.0, it would not compile then). In addition, I'm not convinced this should be changed at the

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-10-13 Thread Ben Cooksley
bcooksley added a comment. You don't have to worry about Phabricator going away, we were on Reviewboard for quite a long time before we started to move away from it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8274 To: shlomif Cc: bcooksley, #frameworks

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

2017-10-13 Thread Shlomi Fish
shlomif created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch copies the symlinked file's contents upon a copy - like /usr/bin/cp instead of creating a new symlink. This is an attempt to fix