D8947: Expose KFilePlacesModel 'iconName' rule

2017-11-22 Thread Friedrich W . H . Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> kfileplacesmodel.h:52
> +GroupRole = 0x0a5b64ee,
> +// @since 5.41
> +IconNameRole = 0x00a45c00

+1 for adding `@since`. But needs  three slashes`///` for doxygen to pick up 
this comment

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8947

To: renatoo, dfaure
Cc: kossebau, #frameworks

D8947: Expose KFilePlacesModel 'iconName' rule

2017-11-22 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8947

To: renatoo, dfaure
Cc: #frameworks

D8947: Expose KFilePlacesModel 'iconName' rule

2017-11-22 Thread Renato Oliveira Filho 
renatoo added a dependent revision: D8948: Created an auxiliary function 
'KFilePlacesModel::movePlace'.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8947

To: renatoo, dfaure
Cc: #frameworks

D8947: Expose KFilePlacesModel 'iconName' rule

2017-11-22 Thread Renato Oliveira Filho 
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8946: Avoid unnecessary 'dataChanged' signal.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8947

To: renatoo, dfaure
Cc: #frameworks

D8947: Expose KFilePlacesModel 'iconName' rule

2017-11-22 Thread Renato Oliveira Filho 
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Make possible for external APIs to get the iconName used in each entry
  of KFilePlacesModel

TEST PLAN
  Unit test created

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8947

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo
Cc: #frameworks