D9784: [ConfigModule] Re-use QML context and engine if any
broulik closed this revision. broulik added a comment. https://cgit.kde.org/kdeclarative.git/commit/?id=84a370ce2c3ac48be9e8745a93cd347bba463323 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9784 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9784: [ConfigModule] Re-use QML context and engine if any
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9784 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9784: [ConfigModule] Re-use QML context and engine if any
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the ConfigModule is created within a QML context, re-use it and its engine instead of creating a shared QML object that might use a different engine. CCBUG: 388766 TEST PLAN Needs a followup patch in Plasma to set the context REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9784 AFFECTED FILES src/quickaddons/configmodule.cpp To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart