Re: Review Request 129090: use ECM variables to find binary

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/
---

(Updated Oct. 18, 2016, 1:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit 4386c4055efe80b0739d2e9104bc44fec239ef0e by Jonathan 
Riddell to branch master.


Repository: kpty


Description
---

use ECM variables to find binary

currently on debian distros the binary isn't found, we use arch specific 
directories which aren't search for with the current search string
this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter


Diffs
-

  cmake/FindUTEMPTER.cmake 2fc1cd8 

Diff: https://git.reviewboard.kde.org/r/129090/diff/


Testing
---

build, it works


Thanks,

Jonathan Riddell

Re: Review Request 129090: use ECM variables to find binary

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review100118
---


Ship it!




Ship It!

- Rohan Garg


On Oct. 18, 2016, 6:25 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129090/
> ---
> 
> (Updated Oct. 18, 2016, 6:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> use ECM variables to find binary
> 
> currently on debian distros the binary isn't found, we use arch specific 
> directories which aren't search for with the current search string
> this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 2fc1cd8 
> 
> Diff: https://git.reviewboard.kde.org/r/129090/diff/
> 
> 
> Testing
> ---
> 
> build, it works
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

Re: Review Request 129090: use ECM variables to find binary

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/
---

(Updated Oct. 18, 2016, 12:55 p.m.)


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

check normal cmake_prefix_path as well as the kde ones


Repository: kpty


Description
---

use ECM variables to find binary

currently on debian distros the binary isn't found, we use arch specific 
directories which aren't search for with the current search string
this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 2fc1cd8 

Diff: https://git.reviewboard.kde.org/r/129090/diff/


Testing
---

build, it works


Thanks,

Jonathan Riddell

Re: Review Request 129090: use ECM variables to find binary

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review100117
---



This has caused a regression on Debian stable where utempter still ships the 
library in ${CMAKE_PREFIX_PATH}/lib/utempter.

Ref https://packages.debian.org/jessie/amd64/libutempter0/filelist

- Rohan Garg


On Oct. 4, 2016, 3:50 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129090/
> ---
> 
> (Updated Oct. 4, 2016, 3:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> use ECM variables to find binary
> 
> currently on debian distros the binary isn't found, we use arch specific 
> directories which aren't search for with the current search string
> this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 8e16d69 
> 
> Diff: https://git.reviewboard.kde.org/r/129090/diff/
> 
> 
> Testing
> ---
> 
> build, it works
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

Re: Review Request 129090: use ECM variables to find binary

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/
---

(Updated Oct. 4, 2016, 12:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit 394eeff0dfba16de7418a25810edde66de541d61 by Jonathan 
Riddell to branch master.


Repository: kpty


Description
---

use ECM variables to find binary

currently on debian distros the binary isn't found, we use arch specific 
directories which aren't search for with the current search string
this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter


Diffs
-

  cmake/FindUTEMPTER.cmake 8e16d69 

Diff: https://git.reviewboard.kde.org/r/129090/diff/


Testing
---

build, it works


Thanks,

Jonathan Riddell

Re: Review Request 129090: use ECM variables to find binary

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review99741
---


Fix it, then Ship it!





cmake/FindUTEMPTER.cmake (line 37)


You can do:

${KDE_INSTALL_FULL_LIBDIR}/utempter


- David Edmundson


On Oct. 3, 2016, 4:28 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129090/
> ---
> 
> (Updated Oct. 3, 2016, 4:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> use ECM variables to find binary
> 
> currently on debian distros the binary isn't found, we use arch specific 
> directories which aren't search for with the current search string
> this finds it hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 8e16d69 
> 
> Diff: https://git.reviewboard.kde.org/r/129090/diff/
> 
> 
> Testing
> ---
> 
> build, it works
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>