Re: Review Request 112902: Start cleanup for kdewebkit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40742 --- kdewebkit/CMakeLists.txt http://git.reviewboard.kde.org/r/112902/#comment29976 again this is not KUNITCONVERSION - David Edmundson On Sept. 24, 2013, 11:19 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- (Updated Sept. 24, 2013, 11:19 a.m.) Review request for KDE Frameworks. Description --- Start to figure out the port of the cmake to KF5 standards. Diffs - staging/kio/src/widgets/renamedialog.h 9a14451 kdewebkit/kwebpage.cpp 73dd5a7 kdewebkit/CMakeLists.txt cdc5835 Diff: http://git.reviewboard.kde.org/r/112902/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112902: Start cleanup for kdewebkit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40743 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 11:19 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- (Updated Sept. 24, 2013, 11:19 a.m.) Review request for KDE Frameworks. Description --- Start to figure out the port of the cmake to KF5 standards. Diffs - staging/kio/src/widgets/renamedialog.h 9a14451 kdewebkit/kwebpage.cpp 73dd5a7 kdewebkit/CMakeLists.txt cdc5835 Diff: http://git.reviewboard.kde.org/r/112902/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112902: Start cleanup for kdewebkit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40642 --- staging/kde4support/CMakeLists.txt http://git.reviewboard.kde.org/r/112902/#comment29915 How is it related to the rest of the patch? staging/kio/src/widgets/renamedialog.h http://git.reviewboard.kde.org/r/112902/#comment29916 How is it related to the rest of the patch? - Kevin Ottens On Sept. 23, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- (Updated Sept. 23, 2013, 5:27 p.m.) Review request for KDE Frameworks. Description --- Start to figure out the port of the cmake to KF5 standards. Diffs - kdewebkit/CMakeLists.txt cdc5835 kdewebkit/kwebpage.cpp 73dd5a7 staging/kde4support/CMakeLists.txt 24ee457 staging/kio/src/widgets/renamedialog.h 9a14451 Diff: http://git.reviewboard.kde.org/r/112902/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112902: Start cleanup for kdewebkit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- Review request for KDE Frameworks. Description --- Start to figure out the port of the cmake to KF5 standards. Diffs - kdewebkit/CMakeLists.txt cdc5835 kdewebkit/kwebpage.cpp 73dd5a7 staging/kde4support/CMakeLists.txt 24ee457 staging/kio/src/widgets/renamedialog.h 9a14451 Diff: http://git.reviewboard.kde.org/r/112902/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
