Re: Review Request 113683: Fix kdeclarative standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- (Updated Nov. 14, 2013, 3:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau. Repository: kdelibs Description --- Make kdeclarative build standalone. Do I need to add the dependencies of all dependencies as well now? Diffs - superbuild/CMakeLists.txt 56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113683: Fix kdeclarative standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43677 --- This review has been submitted with commit 934008a4684befba40cdc50ff4b81682dd03a05f by Maarten De Meyer to branch frameworks. - Commit Hook On Nov. 12, 2013, 7:52 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- (Updated Nov. 12, 2013, 7:52 p.m.) Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau. Repository: kdelibs Description --- Make kdeclarative build standalone. Do I need to add the dependencies of all dependencies as well now? Diffs - superbuild/CMakeLists.txt 56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113683: Fix kdeclarative standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43629 --- Ship it! Ship It! - Kevin Ottens On Nov. 12, 2013, 7:52 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- (Updated Nov. 12, 2013, 7:52 p.m.) Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau. Repository: kdelibs Description --- Make kdeclarative build standalone. Do I need to add the dependencies of all dependencies as well now? Diffs - superbuild/CMakeLists.txt 56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113683: Fix kdeclarative standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau. Repository: kdelibs Description --- Make kdeclarative build standalone. Do I need to add the dependencies of all dependencies as well now? Diffs - superbuild/CMakeLists.txt 56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113683: Fix kdeclarative standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43555 --- Ship it! No, if it works just push it. - Aleix Pol Gonzalez On Nov. 12, 2013, 7:52 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- (Updated Nov. 12, 2013, 7:52 p.m.) Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau. Repository: kdelibs Description --- Make kdeclarative build standalone. Do I need to add the dependencies of all dependencies as well now? Diffs - superbuild/CMakeLists.txt 56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
