Re: Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review50335 --- Ship it! Ship It! - Kevin Ottens On Jan. 28, 2014, 11:48 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 28, 2014, 11:48 a.m.) Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description --- Improve KAuth README.md Diffs - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Feb. 20, 2014, 12:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description --- Improve KAuth README.md Diffs - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 28, 2014, 11:48 a.m.) Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description --- Improve KAuth README.md Diffs (updated) - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 26, 2014, 5:39 p.m.) Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description (updated) --- Improve KAuth README.md Diffs (updated) - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review48325 --- README.md https://git.reviewboard.kde.org/r/114997/#comment34187 Need to use? link against? Also the (or similar) looks unsure. I would say: If you are using cmake, you can find KAuth by using: find_package(KF5Auth NO_MODULE) or finding KF5 with the Auth component, from your CMake scripts. - Aleix Pol Gonzalez On Jan. 26, 2014, 5:39 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 26, 2014, 5:39 p.m.) Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description --- Improve KAuth README.md Diffs - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review48342 --- README.md https://git.reviewboard.kde.org/r/114997/#comment34189 Agreed, this part needs to be less ambiguous. Looks fine otherwise. - Kevin Ottens On Jan. 26, 2014, 5:39 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 26, 2014, 5:39 p.m.) Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description --- Improve KAuth README.md Diffs - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114997: Improve KAuth README.md
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- Review request for KDE Frameworks and Dario Freddi. Repository: kauth Description --- Improve KAuth README.md I'm not really familiar with KAuth, and got this info from skimming the code and techbase tutorial. Could someone more familiar with it check that I haven't made any glaring errors? Diffs - README.md a8a011a147d2dcc0fb5db39e263412005a86def4 Diff: https://git.reviewboard.kde.org/r/114997/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
