Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 6:20 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Fix compilation on MSVC Diffs - src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? - Luigi Toscano On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? two separate commits, however kdoctools is broken on windows so I made it optional to allow building - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- On Jan. 21, 2014, 11:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 11:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building Wouldn't it be better to fix KDocTools on windows instead? :) What is broken? Is it the issue with compiling libxml/libxslt? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47947 --- CMakeLists.txt https://git.reviewboard.kde.org/r/115202/#comment33948 What's the problem with finding documentation on windows? - Aleix Pol Gonzalez On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building Luigi Toscano wrote: Wouldn't it be better to fix KDocTools on windows instead? :) What is broken? Is it the issue with compiling libxml/libxslt? Alexander Richardson wrote: The problem is that it can't find kdex.dtd. I guess I could fix that by copying it the right location, but thats more of a hack. Luigi Toscano wrote: Uhm, on Linux systems you have to set XDG_DATA_DIRS: The value of kde-dir/share must be included in the environment variable XDG_DATA_DIRS or otherwise the build will fail. where kde-dir = your KDE Frameworks 5 installation directory (from http://community.kde.org/Frameworks/Building). I don't know if and how it works on Windows. Alexander Richardson wrote: It is not possible. I will have to modify KDEInstallDirs to get a proper fix. Instead of prefix/share/* we have to install to C:/ProgramData/* or some per-user dir (will have to investigate there, although I don't feel like spending much time on this issue since I rarely use Windows) Can you please at least report this on the TODO list of kde-windows packagers? As I said, I'm not sure this is the right long-term solution, I guess it will happen also for every other frameworks/modules on Windows. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 1:06 a.m.) Review request for KDE Frameworks. Changes --- don't make kdoctools optional Repository: kconfigwidgets Description (updated) --- Fix compilation on MSVC Diffs (updated) - src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
