Re: Review Request 117134: Use QLocale to list all languages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- (Updated March 31, 2014, 2:40 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich. Repository: kconfigwidgets Description --- Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages. Anybody knows if bcp47 compatible with our language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117134: Use QLocale to list all languages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich. Repository: kconfigwidgets Description --- Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages. Anybody knows if bcp47 compatible with our language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117134: Use QLocale to list all languages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/#review54465 --- Same problem as https://git.reviewboard.kde.org/r/117132/ : this code is supposed to list the available translations. The new code doesn't do that. Is was using entry.desktop, maybe it can look up myapp.gmo files instead. But it has to be based on what is actually installed. - David Faure On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- (Updated March 28, 2014, 11:50 a.m.) Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich. Repository: kconfigwidgets Description --- Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages. Anybody knows if bcp47 compatible with our language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117134: Use QLocale to list all languages
On March 28, 2014, 3:51 p.m., David Faure wrote: Same problem as https://git.reviewboard.kde.org/r/117132/ : this code is supposed to list the available translations. The new code doesn't do that. Is was using entry.desktop, maybe it can look up myapp.gmo files instead. But it has to be based on what is actually installed. Not really, it's looking up all languages (as they are installed by kde-runtime). All users should have all entry.desktop files, not only the ones that you have available for translation, AFAIU. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/#review54465 --- On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- (Updated March 28, 2014, 11:50 a.m.) Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich. Repository: kconfigwidgets Description --- Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages. Anybody knows if bcp47 compatible with our language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117134: Use QLocale to list all languages
On March 28, 2014, 3:51 p.m., David Faure wrote: Same problem as https://git.reviewboard.kde.org/r/117132/ : this code is supposed to list the available translations. The new code doesn't do that. Is was using entry.desktop, maybe it can look up myapp.gmo files instead. But it has to be based on what is actually installed. Aleix Pol Gonzalez wrote: Not really, it's looking up all languages (as they are installed by kde-runtime). All users should have all entry.desktop files, not only the ones that you have available for translation, AFAIU. David Faure wrote: In my KDE4 environment (where kde-runtime is definitely installed, but no translations installed), I run klanguagebuttontest in kdeui and I get only English. Found it: you're confusing countries and languages. kde-runtime installs countries into share/locale/l10n/*/entry.desktop KLanguageButton looks for entry.desktop files in share/locale/*/entry.desktop(no l10n subdir!). Alright, then there is 2 kinds of entry.desktop files. My bad... I'll discard the patch for now until I understand life back again. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/#review54465 --- On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- (Updated March 28, 2014, 11:50 a.m.) Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich. Repository: kconfigwidgets Description --- Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages. Anybody knows if bcp47 compatible with our language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
