Re: Review Request 124226: Delete old highlighter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/ --- (Updated July 12, 2015, 8:12 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Laurent Montel. Repository: ktextwidgets Description --- According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted. This fixes bug 343459 in Lokalize. Diffs - src/widgets/ktextedit.cpp e4bd41d Diff: https://git.reviewboard.kde.org/r/124226/diff/ Testing --- Tested that it works in Lokalize. Also ran tests. Thanks, Lasse Liehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124226: Delete old highlighter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/#review82351 --- Ship it! Ship it. Indeed I did it in kmail too. Thanks - Laurent Montel On juil. 11, 2015, 8:18 matin, Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/ --- (Updated juil. 11, 2015, 8:18 matin) Review request for KDE Frameworks and Laurent Montel. Repository: ktextwidgets Description --- According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted. This fixes bug 343459 in Lokalize. Diffs - src/widgets/ktextedit.cpp e4bd41d Diff: https://git.reviewboard.kde.org/r/124226/diff/ Testing --- Tested that it works in Lokalize. Also ran tests. Thanks, Lasse Liehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124226: Delete old highlighter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/ --- (Updated July 11, 2015, 8:18 a.m.) Review request for KDE Frameworks and Laurent Montel. Changes --- Removed unnecessary if. Repository: ktextwidgets Description --- According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted. This fixes bug 343459 in Lokalize. Diffs (updated) - src/widgets/ktextedit.cpp e4bd41d Diff: https://git.reviewboard.kde.org/r/124226/diff/ Testing --- Tested that it works in Lokalize. Also ran tests. Thanks, Lasse Liehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124226: Delete old highlighter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/ --- Review request for KDE Frameworks and Laurent Montel. Repository: ktextwidgets Description --- According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted. This fixes bug 343459 in Lokalize. Diffs - src/widgets/ktextedit.cpp e4bd41d Diff: https://git.reviewboard.kde.org/r/124226/diff/ Testing --- Tested that it works in Lokalize. Also ran tests. Thanks, Lasse Liehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124226: Delete old highlighter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/#review81973 --- src/widgets/ktextedit.cpp (line 662) https://git.reviewboard.kde.org/r/124226/#comment56298 no need for the if, you can just call `delete decorator-highlighter();` Also this is weird, deleting a returned attribute is not common, maybe KTextDecorator should delete it? - Aleix Pol Gonzalez On July 1, 2015, 9:02 p.m., Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/ --- (Updated July 1, 2015, 9:02 p.m.) Review request for KDE Frameworks and Laurent Montel. Repository: ktextwidgets Description --- According to SpellCheckDecorator::setHighlighter's documentation, the old automatically created default highlighter must be manually deleted. This fixes bug 343459 in Lokalize. Diffs - src/widgets/ktextedit.cpp e4bd41d Diff: https://git.reviewboard.kde.org/r/124226/diff/ Testing --- Tested that it works in Lokalize. Also ran tests. Thanks, Lasse Liehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
