Re: Review Request 125536: Remove unused variable warnings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/ --- (Updated Feb. 19, 2016, 12:16 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: karchive Description --- Remove unused zip mime In k7zip i've opted for commenting instead of reverting since these magic values may be hard to get again if needed and whoever sees it may not realize it was part of the history and git log it Diffs - src/k7zip.cpp 64c6b52 src/ktar.cpp 49a6791 Diff: https://git.reviewboard.kde.org/r/125536/diff/ Testing --- clang compiles without warnings Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125536: Remove unused variable warnings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/#review90276 --- ping? - Albert Astals Cid On oct. 5, 2015, 10:41 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125536/ > --- > > (Updated oct. 5, 2015, 10:41 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > --- > > Remove unused zip mime > In k7zip i've opted for commenting instead of reverting since these magic > values may be hard to get again if needed and whoever sees it may not realize > it was part of the history and git log it > > > Diffs > - > > src/k7zip.cpp 64c6b52 > src/ktar.cpp 49a6791 > > Diff: https://git.reviewboard.kde.org/r/125536/diff/ > > > Testing > --- > > clang compiles without warnings > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125536: Remove unused variable warnings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/#review90277 --- Related: https://git.reviewboard.kde.org/r/126429/ - Aleix Pol Gonzalez On Oct. 6, 2015, 12:41 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125536/ > --- > > (Updated Oct. 6, 2015, 12:41 a.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > --- > > Remove unused zip mime > In k7zip i've opted for commenting instead of reverting since these magic > values may be hard to get again if needed and whoever sees it may not realize > it was part of the history and git log it > > > Diffs > - > > src/k7zip.cpp 64c6b52 > src/ktar.cpp 49a6791 > > Diff: https://git.reviewboard.kde.org/r/125536/diff/ > > > Testing > --- > > clang compiles without warnings > > > Thanks, > > Albert Astals Cid > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125536: Remove unused variable warnings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/ --- Review request for KDE Frameworks. Repository: karchive Description --- Remove unused zip mime In k7zip i've opted for commenting instead of reverting since these magic values may be hard to get again if needed and whoever sees it may not realize it was part of the history and git log it Diffs - src/k7zip.cpp 64c6b52 src/ktar.cpp 49a6791 Diff: https://git.reviewboard.kde.org/r/125536/diff/ Testing --- clang compiles without warnings Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
