T3689: Add abi compliance checker to CI

knauss added a revision: D21168: create-abi-dump: Handle clang/*/include directories.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D20769: abi-compliance-checker: disable clang include directories completly.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning,

T3689: Add abi compliance checker to CI

knauss added a subtask: T10504: Abi compliance checker flaky/not working. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19410: create-abi-dump: Do not break for library, that don't have a SONAME.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning,

T3689: Add abi compliance checker to CI

knauss added a revision: D19377: check-abi: refactor script. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19376: remove unnessary include.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19375: check-abi: make it possible to break the build.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19374: create-abi-dump: set logging for paramiko.transport to WARNING. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

bcooksley added a comment. With the exception of D19222 all of those have now been integrated. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin,

T3689: Add abi compliance checker to CI

knauss added a comment. Please merge the commits in following order: D19219 D19220 D19221 D19222 D19218

T3689: Add abi compliance checker to CI

knauss added a revision: D19218: create-abi-dump: small cleanup. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19221: create-abi-dump: Let make it possible for create-abi-dump to break a build.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin,

T3689: Add abi compliance checker to CI

knauss added a revision: D19222: create-abi-dump/check-abi: implement new accMetadata.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19220: create-abi-dump: match new jenkings log format.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19219: create-abi-dumps: do more debugging.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

bcooksley added a comment. Build logs from our Docker images can be found at https://build.kde.org/job/Administration/ In this case, the image last changed 26 days ago. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: danders, davidedmundson, dfaure,

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#175858 , @danders wrote: > Afaiu abi-dumper is the new way of creating dumps. From home page: > "This new way is based on the analysis of the debug-info from binary objects. It's more reliable, faster and

T3689: Add abi compliance checker to CI

danders added a comment. In T3689#175818 , @knauss wrote: > So far I understood abi-dumper is something different - I use abi-complience-checker to create those dumps. Afaiu abi-dumper is the new way of creating dumps. From home page:

T3689: Add abi compliance checker to CI

knauss added a comment. To create a dump by hand this isn't that easy. see sysadmins/ci-tooling/helpers/create-abi-dump.py. > I was unsuccesful using abi-dumper So far I understood abi-dumper is something different - I use abi-complience-checker to create those dumps. As you

T3689: Add abi compliance checker to CI

danders added a comment. Hmmm. do not know how to proceed with this without the actual libs available. I have tried building against a new lib and runing with old lib, with no problems. I was unsuccesful using abi-dumper on the old lib, so cannot check if it gives the same output as for

T3689: Add abi compliance checker to CI

knauss added a comment. I'm not a expert in abi-complience-checker, so we need to find out together... In T3689#175022 , @danders wrote: > The ABI error started with build 4:

T3689: Add abi compliance checker to CI

danders added a comment. I get ABI error on use of QPair and QSet in kdiagram: https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/8/artifact/compat_reports/KGantt_compat_report.html#Type_Binary_Problems_Medium Afaics these lines have not been changed since last

T3689: Add abi compliance checker to CI

knauss added a comment. YEAH so far the abi-compatibility-results.yaml for pim and Frameworks, as far as they got update the last days. So we are surly hitting the end of this and catching up the loosen tails of all of this. I'll focus currently on other stuff, will look at it and fix

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17880: check-abi: Fix error logging for non compatible builds.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17843: python3.6 has no capture_output paramenter for subprocess.run.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17837: Switch to the new syntax (spaces -> tabs).. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17836: add clang/7.0.0/include to make abi-compliance-checker happy again.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17798: publish acc build logs as artifacts.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#170799 , @davidedmundson wrote: > > kwayland > > > > KWayland/Client/xdgforeign_v2.h -> missing include "xdgforeign.h" > > This is now hopefully fixed. Please let me know if it's still an issue.

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17770: create a YAML file for further processing the output of abi-compliance-checker.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning,

T3689: Add abi compliance checker to CI

knauss added a revision: D17769: activate syntax ( replace spaces -> tabs.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

davidedmundson added a comment. > kwayland > > KWayland/Client/xdgforeign_v2.h -> missing include "xdgforeign.h" This is now hopefully fixed. Please let me know if it's still an issue. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, davidedmundson Cc: davidedmundson,

T3689: Add abi compliance checker to CI

knauss added a comment. I have made sure that kde/pim is now cleanup in terms of the issue of "not runnig ABI", by triggering a rebuilt. So it is a good test if the patch is working. With more tests I have detected, that builds still use the oldest commit instead of tags commits (fix

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17745: resolve tags to the commit, that was tagged.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

bcooksley added a comment. I've made an experimental change which should resolve this issue if it is what is suspected to be the issue here. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid,

T3689: Add abi compliance checker to CI

bcooksley added a commit: R857:dbb3d8d9f37a: Make sure we wait and block until the publishing process is completed.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning,

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#170601 , @bcooksley wrote: > I checked execution of KDav on all four build nodes, and the process ran fine when done manually. > Given there is no output from check-abi.py, this is quite hard to diagnose.

T3689: Add abi compliance checker to CI

knauss added a revision: D17710: check-abi.py: Reload serverManiphest several times, if we don't find matching entries.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

bcooksley added a comment. I checked execution of KDav on all four build nodes, and the process ran fine when done manually. Given there is no output from check-abi.py, this is quite hard to diagnose. Can you propose some debug output which might point out why it's doing nothing?

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#170284 , @bcooksley wrote: > In regards to `akonadi-mime` I have now re-run it, and it seems to work fine. > As long as you're relying only on the master manifest.yaml, then it should be impossible for any

T3689: Add abi compliance checker to CI

knauss added a revision: D17672: Move settings for abi-complience-checker to own yaml file.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

bcooksley added a comment. Okay, there have been a number of comments here since i've last read it, so a bit to catch up on and go over. In regards to `akonadi-mime` I have now re-run it, and it seems to work fine. As long as you're relying only on the master manifest.yaml, then it

T3689: Add abi compliance checker to CI

knauss added a revision: D17579: Handle cases where tailing "/" in CMAKE_PREFIX_PATH fails the detection of additional include directories.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss,

T3689: Add abi compliance checker to CI

knauss added a comment. @bcooksley for akonadi-search we need some special settings for the abi-create step. Where we should store such settings? This is a more general solution, that we can also modify the settings for other platforms etc.

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a comment. okay with merging D17534 CI now successfully builds the abis for the mentioned packages. (I modified the last comment) TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley,

T3689: Add abi compliance checker to CI

knauss added a comment. I use the ci-docker images to test the create-abi, but I can't reproduce why those are failing: - messagelib - kdav - libksieve - akonadi-import-wizard - kpkpass - libkgapi maybe those are also fixed by D17534

T3689: Add abi compliance checker to CI

knauss added a comment. I now looked at every repository that failed to build successfully a ABI dump for Pim. Most of them build successful, but a few of them have issues: - kmime has an unexported header in kmime/kmime_newsarticle.h: `#include ` that lives in src/supertrait.h -

T3689: Add abi compliance checker to CI

knauss added subscribers: kde-frameworks-devel, dfaure. knauss added a comment. I now looked at every repository that failed to build successfully a ABI dump for Frameworks. As I'm not really deep into the Framworks code, so I'm unsure, if those are real issues or if those Frameworks need