Re: Where's kf5_add_ui_files ?

2013-12-17 Thread Chusslove Illich 
 [: Aleix Pol :]
 FWIW, how could this have worked before? :/

There was an initial patch, then some weeks of hiatus and discussion, and
then it was committed very recently as a stop-gap measure. Probably
something got lost in the process.

-- 
Chusslove Illich (Часлав Илић)


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Chusslove Illich 
 [: Albert Astals Cid :]
 ki18n_wrap_ui doesn't seem to be usable outside kdelibs.

   [ 51%] Generating ui_kgamethemeselector.h
   CMake Error: Error processing file: /kf5i18nuic.cmake

I guess the proper fix is largely a matter of convention, which I don't know
what it is. But does the attached patch solve the problem?

-- 
Chusslove Illich (Часлав Илић)
diff --git a/tier2/ki18n/cmake/KF5I18NMacros.cmake b/tier2/ki18n/cmake/KF5I18NMacros.cmake
index ac557ed..1bf2fa1 100644
--- a/tier2/ki18n/cmake/KF5I18NMacros.cmake
+++ b/tier2/ki18n/cmake/KF5I18NMacros.cmake
@@ -24,7 +24,7 @@ macro (KI18N_WRAP_UI _sources )
  -DKDE_UIC_FILE:FILEPATH=${_tmp_FILE}
  -DKDE_UIC_H_FILE:FILEPATH=${_header}
  -DKDE_UIC_BASENAME:STRING=${_basename}
- -P ${KI18N_MODULE_DIR}/kf5i18nuic.cmake
+ -P ${CMAKE_CURRENT_LIST_DIR}/kf5i18nuic.cmake
  MAIN_DEPENDENCY ${_tmp_FILE}
   )
   list(APPEND ${_sources} ${_header})


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Albert Astals Cid 
El Dilluns, 16 de desembre de 2013, a les 19:46:51, Chusslove Illich va 
escriure:
  [: Albert Astals Cid :]
  ki18n_wrap_ui doesn't seem to be usable outside kdelibs.
  
[ 51%] Generating ui_kgamethemeselector.h
CMake Error: Error processing file: /kf5i18nuic.cmake
 
 I guess the proper fix is largely a matter of convention, which I don't know
 what it is. But does the attached patch solve the problem?

No, that doesn't help

[ 51%] Generating ui_kgamethemeselector.h
CMake Error: Error processing file: 
/home/frameworks/libkdegames/kf5i18nuic.cmake

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Chusslove Illich 
 [: Albert Astals Cid :]
 No, that doesn't help

   [ 51%] Generating ui_kgamethemeselector.h
   CMake Error: Error processing file: 
 /home/frameworks/libkdegames/kf5i18nuic.cmake

How about this instead?

-- 
Chusslove Illich (Часлав Илић)
diff --git a/tier2/ki18n/KF5I18nConfig.cmake.in b/tier2/ki18n/KF5I18nConfig.cmake.in
index dcd..dd3b92e 100644
--- a/tier2/ki18n/KF5I18nConfig.cmake.in
+++ b/tier2/ki18n/KF5I18nConfig.cmake.in
@@ -3,6 +3,8 @@
 find_dependency(KF5JS @KF5_VERSION@)
 
 
+set(KI18N_MODULE_DIR ${PACKAGE_PREFIX_DIR}/@CMAKECONFIG_INSTALL_DIR@)
+
 include(${CMAKE_CURRENT_LIST_DIR}/KF5I18nTargets.cmake)
 include(${CMAKE_CURRENT_LIST_DIR}/KF5I18NMacros.cmake)
 


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Albert Astals Cid 
El Dilluns, 16 de desembre de 2013, a les 22:07:39, Chusslove Illich va 
escriure:
  [: Albert Astals Cid :]
  No, that doesn't help
  
[ 51%] Generating ui_kgamethemeselector.h
CMake Error: Error processing file:
/home/frameworks/libkdegames/kf5i18nuic.cmake
 How about this instead?

This works.

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-16 Thread Aleix Pol 
On Mon, Dec 16, 2013 at 10:35 PM, Chusslove Illich caslav.i...@gmx.netwrote:

  [: Albert Astals Cid :]
  This works.

 And it actually looks like things done in some other modules, so I
 committed
 it. Thanks for the checks.

 --
 Chusslove Illich (Часлав Илић)

 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


FWIW, how could this have worked before? :/

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-15 Thread Chusslove Illich 
 [: Albert Astals Cid :]
 tier2/ki18n/Mainpage.dox says
   * If CMake is used as the build system, a macro that performs
   * all of the above is provided (\c kf5_add_ui_files).

 But I can't seem to use it at all in my CMakeLists.txt.

Documentation out of date, it is named ki18n_wrap_ui. Fixed.


-- 
Chusslove Illich (Часлав Илић)


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

2013-12-15 Thread Albert Astals Cid 
El Diumenge, 15 de desembre de 2013, a les 18:01:24, Chusslove Illich va 
escriure:
  [: Albert Astals Cid :]
  tier2/ki18n/Mainpage.dox says
  
* If CMake is used as the build system, a macro that performs
* all of the above is provided (\c kf5_add_ui_files).
  
  But I can't seem to use it at all in my CMakeLists.txt.
 
 Documentation out of date, it is named ki18n_wrap_ui. Fixed.

Chussolve already knows, but answering here for it to be known for everybody.

ki18n_wrap_ui doesn't seem to be usable outside kdelibs.

[ 51%] Generating ui_kgamethemeselector.h
CMake Error: Error processing file: /kf5i18nuic.cmake


Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel