[Differential] [Changed Subscribers] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

2017-02-15 Thread Sergio Martins
smartins added inline comments. INLINE COMMENTS > kdirwatch.cpp:1379 > > -Q_FOREACH (Client *c, e->m_clients) { > -if (c->instance == nullptr || c->count == 0) { > +for (Client : e->m_clients) { > +if (c.instance == nullptr || c.count == 0) { can m_clients be shared ?

[Differential] [Changed Subscribers] D4584: KDirWatch: replace QList by std::vector to save on new/delete.

2017-02-12 Thread Milian Wolff
mwolff added inline comments. INLINE COMMENTS > kdirwatch.cpp:371 > // files in WatchFiles mode with inotify. > if (isDir) { > addEntry(client->instance, tpath, > nullptr, isDir, future patch