kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember
> KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if
> CMAKE_INSTALL_PREFIX was /usr.
>
> Ok, so the
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> Fear I am still missing what you mean. So let's go explicitely, here is what
> I understand to happen:
>
> There are six different cases when using this macro and on the first
> invocation of cmake,
kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> It is :) But with this latest revision it is not when that var is off =) I'm
> saying that for both cases it should happen.
Fear I am still missing what you mean. So let's go explicitely, here is what
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as
> well?
> At least this is how I understand
>
kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> Right. But if you install a framework to same prefix as Qt, you get free
> recognition of plugins, qml imports, etc... This is valid for both /usr and
> custom prefix installs.
> I guess what i want
kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> I mean, addition of qch subdir is 'your' invention here.
> If Frameworks were to use only qmake build-system, i'm sure qch files would
> end up in QT_INSTALL_DOCS directory.
> I.e. for
kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla
> Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS
> ...
Not sure what you mean, please point out
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> Not sure what you mean, please point out the issue you see here with more
> details :)
>
> The plan here is:
> if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS,
> if not,
shumski added inline comments.
INLINE COMMENTS
> KDEInstallDirs.cmake:534
> +else()
> +_define_relative(QTQCHDIR DATAROOTDIR "doc/QCH"
> +"documentation bundles in QCH format for Qt-extending libraries")
I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla Qt's.
kossebau added a comment.
In https://phabricator.kde.org/D2854#64179, @shumski wrote:
> > a) recommended install path for qch and tag files?
>
> At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use
QT_INSTALL_DOCS (via ECMQueryQmake) var.
Good proposal, I think
shumski added a comment.
> a) recommended install path for qch and tag files?
At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use
QT_INSTALL_DOCS (via ECMQueryQmake) var.
REVISION DETAIL
https://phabricator.kde.org/D2854
EMAIL PREFERENCES
11 matches
Mail list logo
