[Differential] [Commented On] D4414: don't regenerate frames when setting every property

2017-02-15 Thread David Rosca
drosca added a comment. I now get tons of binding loop errors from FrameSvgItem, it also breaks delegates in networkmanager and bluetooth applets. On the screenshot you can see that the last 3 delegates (HUAWEI, UPC and Internet) are slightly moved to the left and hovering over them will

[Differential] [Commented On] D4414: don't regenerate frames when setting every property

2017-02-07 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > mart wrote in framesvg.cpp:136 > it has pendingEnabledBorders because right now the borders are saved only n > the frame, that we don't know if we can keep it or we'll have to throw it > away ( or just dereference because some other

[Differential] [Commented On] D4414: don't regenerate frames when setting every property

2017-02-07 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvg.cpp:136 > I'm lost on why we have the pendingEnabledBorders > > you have some bugs if you do: > > setRepaintBlocked(false); > setEnabledBorders(Left) > enabledBorders() /// returns All not Left. > > it'll get