[Differential] [Commented On] D4589: EditorConfig module

dhaumann added inline comments. INLINE COMMENTS > Findeditorconfig.cmake:2 > +# > +# Copyright (c) 2016 João Valverde > +# All rights reserved. 1. Please add yourself as copyright holder. 2. Could you have a look at the comments at the very top of the other

[Differential] [Commented On] D4589: EditorConfig module

dhaumann added a comment. Hm, looking at libgit2 I have: -rwxr-xr-x 1 root root 906728 Dez 2 12:13 libgit2.so.0.24.0 lrwxrwxrwx 1 root root 17 Jan 7 20:05 libgit2.so.24 -> libgit2.so.0.24.0 Looking at editorconfig, I have: lrwxrwxrwx 1 root root20 Feb 12 17:17

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. editorconfig-core-lua doesn’t check C library version (CMakeLists.txt:49 ). Actually I’m not sure if setting oldest

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. It seems there isn’t any version string in library headers (editorconfig.h, editorconfig_handle.h), is there any other cross-distribution way to obtain library version? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4589

[Differential] [Commented On] D4589: EditorConfig module

dhaumann added a comment. Correct is that we want to write find_package(editorconfig "0.12.0) i.e., with a version. This is missing in this find module, see the LibGit2 find module. Could you extend this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL