adridg marked 5 inline comments as done.
adridg added inline comments.
INLINE COMMENTS
> kfunk wrote in FindInotify.cmake:51
> Style: Indent off
Assuming that means "comments indent 0" and not "comments indentation should
match surrounding indent, which is 4". It's a bit ambiguous.
> kfunk
dfaure added a comment.
OK I see. On Linux it was enough to check that the header is present (-> in
/usr/include) while on BSD it's part of a library that could in theory be
installed anywhere. Makes sense to set an _INCLUDE_DIRS variable then.
REPOSITORY
R240 Extra CMake Modules
dfaure added a reviewer: skelly.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3826
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: adridg, apol, arrowdodger, #buildsystem, #frameworks, tcberner,
ervin added a comment.
Not my forte, but I don't see anything blatantly wrong in here. Adding dfaure
to see if he got something to say about it.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3826
EMAIL PREFERENCES
ervin added a reviewer: dfaure.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3826
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: adridg, apol, arrowdodger, #buildsystem, #frameworks, ervin, tcberner,
adridg added a reviewer: ervin.
adridg added a comment.
Adding Kevin as reviewer -- I feel uncomfortable having so little feedback
and I'm not sure who should be added if
https://phabricator.kde.org/tag/buildsystem/ and
https://phabricator.kde.org/tag/frameworks/ don't ACK.
REPOSITORY
