Re: [Review Request] Modularizing KF5

2013-10-02 Thread Aurélien Gâteau
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think it's important to get it done and I'd rather go reasonably fast with it before we start getting too much

Re: [Review Request] Modularizing KF5

2013-10-02 Thread Aurélien Gâteau
On Wednesday 02 October 2013 10:14:12 Aurélien Gâteau wrote: On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think it's important to get it done and I'd

Re: [Review Request] Modularizing KF5

2013-10-02 Thread Stephen Kelly
Aurélien Gâteau wrote: On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think it's important to get it done and I'd rather go reasonably fast with it before we

Re: [Review Request] Modularizing KF5

2013-10-02 Thread Aleix Pol
On Wed, Oct 2, 2013 at 10:25 AM, Stephen Kelly steve...@gmail.com wrote: Aurélien Gâteau wrote: On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think

Re: [Review Request] Modularizing KF5

2013-10-02 Thread Stephen Kelly
Aleix Pol wrote: I pushed a couple of new commits that remove the usage of macro_bool_to_01 and the HAVE_QSSLSOCKET thing. I assume you have no intention of merging that branch? The top commit looks fine at least. Please cherry-pick it to frameworks, and rebase and clean-up the rest of

[Review Request] Modularizing KF5

2013-10-01 Thread Aleix Pol
Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think it's important to get it done and I'd rather go reasonably fast with it before we start getting too much conflicts. This patch removes all find_package usages in