Re: Allowing kicontheme tests to run without oxygen-icons

2013-12-19 Thread David Faure
On Wednesday 18 December 2013 23:32:13 Alex Merry wrote: > Currently, kiconthemes tests fail on Jenkins, due to the absense of > oxygen-icons. But I figured they shouldn't really depend on a theme > being installed anyway, so I altered the tests to not require it. > > Reviewboard doesn't have the

Re: Allowing kicontheme tests to run without oxygen-icons

2013-12-18 Thread Ben Cooksley
On Thu, Dec 19, 2013 at 12:32 PM, Alex Merry wrote: > Currently, kiconthemes tests fail on Jenkins, due to the absense of > oxygen-icons. But I figured they shouldn't really depend on a theme > being installed anyway, so I altered the tests to not require it. This is because the kiconthemes fram

Allowing kicontheme tests to run without oxygen-icons

2013-12-18 Thread Alex Merry
Currently, kiconthemes tests fail on Jenkins, due to the absense of oxygen-icons. But I figured they shouldn't really depend on a theme being installed anyway, so I altered the tests to not require it. Reviewboard doesn't have the new repos yet, so patch is attached. If this idea meets general a