Re: Bulk replacement of projects.kde.org on Frameworks modules
On samedi 16 novembre 2019 16:25:37 CET Luigi Toscano wrote: > Luigi Toscano ha scritto: > > Hi, > > basically all Frameworks components reference the ECM website > > using the old projects.kde.org URL, which is long gone and > > it is just a (partial) redirect. > > > > See for example: > > > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > > > > DESCRIPTION "Extra CMake Modules." > > URL > > "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) > > > > Can I go around a bulk-replace all the URLs with > > https://commits.kde.org/extra-cmake-modules, so that it would look like: > > > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > > > > DESCRIPTION "Extra CMake Modules." > > URL "https://commits.kde.org/extra-cmake-modules;) > > > > There are few additional URLs which use the old website and I would > > replace > > them as well using the same pattern. > > > > I'm asking to avoid ~70 almost-identical review requests. > > Apart from Elvis (here) and Volker (on IRC), any other ack? (looking > especially for dfaure :) Ack for a global search/replace without review. No idea about which URL to use though, I'll trust you and others about that. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: Bulk replacement of projects.kde.org on Frameworks modules
Luigi Toscano ha scritto: > Hi, > basically all Frameworks components reference the ECM website > using the old projects.kde.org URL, which is long gone and > it is just a (partial) redirect. > > See for example: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra CMake Modules." > URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) > > Can I go around a bulk-replace all the URLs with > https://commits.kde.org/extra-cmake-modules, so that it would look like: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra CMake Modules." > URL "https://commits.kde.org/extra-cmake-modules;) > > There are few additional URLs which use the old website and I would replace > them as well using the same pattern. > > I'm asking to avoid ~70 almost-identical review requests. Apart from Elvis (here) and Volker (on IRC), any other ack? (looking especially for dfaure :) Ciao -- Luigi
Re: Bulk replacement of projects.kde.org on Frameworks modules
Elvis Angelaccio ha scritto: > > > On 11/11/19 22:52, Luigi Toscano wrote: >> Hi, >> basically all Frameworks components reference the ECM website >> using the old projects.kde.org URL, which is long gone and >> it is just a (partial) redirect. >> >> See for example: >> >> set_package_properties(ECM PROPERTIES TYPE REQUIRED >> DESCRIPTION "Extra CMake Modules." >> URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) >> >> Can I go around a bulk-replace all the URLs with >> https://commits.kde.org/extra-cmake-modules, so that it would look like: >> >> set_package_properties(ECM PROPERTIES TYPE REQUIRED >> DESCRIPTION "Extra CMake Modules." >> URL "https://commits.kde.org/extra-cmake-modules;) > > +1 > > Using commits.kde.org like this feels weird though (i.e. using it > without a commit hash). commits.kde.org is the general redirector, and it will continue to work even after the switch to gitlab. We have a bit of documentation here: https://techbase.kde.org/Projects/Documentation/KDE_(health_table)#Links_to_kde_repos Ciao -- Luigi
Re: Bulk replacement of projects.kde.org on Frameworks modules
On 11/11/19 22:52, Luigi Toscano wrote: > Hi, > basically all Frameworks components reference the ECM website > using the old projects.kde.org URL, which is long gone and > it is just a (partial) redirect. > > See for example: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra CMake Modules." > URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) > > Can I go around a bulk-replace all the URLs with > https://commits.kde.org/extra-cmake-modules, so that it would look like: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra CMake Modules." > URL "https://commits.kde.org/extra-cmake-modules;) +1 Using commits.kde.org like this feels weird though (i.e. using it without a commit hash). Something like https://code.kde.org/extra-cmake-modules would look much better imho. Just my 2c, maybe something that could be done after the move to gitlab. > > There are few additional URLs which use the old website and I would replace > them as well using the same pattern. > > I'm asking to avoid ~70 almost-identical review requests. > > Ciao > Ciao Elvis
Bulk replacement of projects.kde.org on Frameworks modules
Hi, basically all Frameworks components reference the ECM website using the old projects.kde.org URL, which is long gone and it is just a (partial) redirect. See for example: set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) Can I go around a bulk-replace all the URLs with https://commits.kde.org/extra-cmake-modules, so that it would look like: set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules;) There are few additional URLs which use the old website and I would replace them as well using the same pattern. I'm asking to avoid ~70 almost-identical review requests. Ciao -- Luigi
