D10325: RFC: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik added a comment.


  > Would it be possible to show it as if it were locked? That would solve all 
the issues with it, right?
  
  I don't get it. That "lock" feature is entirely a Dolphin invention. It does 
exactly what I do here:
  
void DolphinDockWidget::setLocked(bool lock)
{
...
if (lock) {
...
setTitleBarWidget(m_dockTitleBar);
setFeatures(QDockWidget::NoDockWidgetFeatures);
  
  with `m_dockTitleBar` being a custom widget for some added padding

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Mark Gaiser]

markg added a comment.


  Why does it show the panel as if it were unlocked?
  Your before image looks exactly like an unlocked frame in Dolphin.
  
  Would it be possible to show it as if it were locked? That would solve all 
the issues with it, right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Nathaniel Graham]

ngraham added a comment.


  OK, great.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks
Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik added a comment.


  > Shouldn't this be controlled by System Settings > Application Style > 
Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels?
  
  If that option is enabled you get a frame even with this patch. Otherwise, 
the default, is nice and clean.
  F5693305: Screenshot_20180205_163418.png 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks
Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Nathaniel Graham]

ngraham added a comment.


  Shouldn't this be controlled by System Settings > Application Style > Widget 
Style > Breeze > Configure > Frames > Draw Frame around Dockable panels? 
Otherwise, people who check that setting will have a visible frame around the 
Places panel in Dolphin, but not in open/save file pickers, and will wonder why 
and file bugs about it. I know it's technically not a dockable panel, but IMHO 
visual consistency is more important than technical consistency here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks
Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10325: RFC: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This avoids a double "Places" header and also gets rid of the superfluous 
frame around the widget, similar to Dolphin. It has never been possible to 
detach the dock from the window anyway.
  The close button is also removed as a side-effect of this but should a user 
really want to hide it, this can still be done by pressing F9 or in the menu. 
Resizing the places list is still possible.

TEST PLAN
  Before
  F5693291: Screenshot_20180205_161053.png 

  After
  F5693292: Screenshot_20180205_161002.png 

  
  I just noticed in Oxygen it always paints a frame around it and you end up 
with a lot of padding at the top.
  When I completely remove the header item, it looks strange with the places 
crammed at the top:
  F5693295: Screenshot_20180205_161901.png 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: broulik, #plasma, #vdg, #frameworks
Cc: plasma-devel, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart